Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiddify-next: init at 1.1.1 #303085

Closed
wants to merge 2 commits into from
Closed

Conversation

wenjinnn
Copy link

@wenjinnn wenjinnn commented Apr 10, 2024

init with appimage version
fix #285375, related #287770
also add wenjinnn to maintainer-list

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 10, 2024
@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from b09d97a to 07f67cb Compare April 10, 2024 11:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 10, 2024
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs! Make sure to put new packages in pkgs/by-name. You can also format your code with nixfmt-rfc-style

pkgs/applications/networking/hiddify-next/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/hiddify-next/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/hiddify-next/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/hiddify-next/default.nix Outdated Show resolved Hide resolved
@donovanglover
Copy link
Member

When you're done, make sure that you have 2 separate commits in this order:

  1. maintainers: add wenjinnn
  2. hiddify-next: init at 1.1.1

@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from 07f67cb to 7a38808 Compare April 10, 2024 15:18
@wenjinnn
Copy link
Author

When you're done, make sure that you have 2 separate commits in this order:

  1. maintainers: add wenjinnn
  2. hiddify-next: init at 1.1.1

All done! thanks for the suggestion and guide.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 10, 2024
@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from 7a38808 to e119d25 Compare April 14, 2024 07:42
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3855

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 2, 2024
@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from 7e597a8 to 480d0b6 Compare June 2, 2024 05:00
@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from 480d0b6 to a889c57 Compare June 2, 2024 07:12
@wenjinnn
Copy link
Author

wenjinnn commented Jun 2, 2024

Seems like after 24.05 release, appimageTools.wrapType2 behavior changed. after 24.05, this command will fail:

    mv $out/bin/hiddify-next-1.1.1 $out/bin/hiddify

now the location $out/bin/hiddify-next-1.1.1 change to $out/bin/hiddify-next, so I make some change to adapt this behavior.

init with appimage version
@wenjinnn wenjinnn force-pushed the wenjinnn/hiddify-next branch from a889c57 to 32b565f Compare June 3, 2024 10:38
@linsui
Copy link
Contributor

linsui commented Jul 11, 2024

Since hidiffy violates the license used by sing-box I thought we shouldn't package it.

@wenjinnn
Copy link
Author

Well, I'm ok with that reason. should we close this PR now or wait for confirmation from others?

@BeiyanYunyi BeiyanYunyi mentioned this pull request Jul 11, 2024
13 tasks
@wenjinnn
Copy link
Author

wenjinnn commented Oct 22, 2024

Clost this since #326367 pack it from source. Thanks everyone.

@wenjinnn wenjinnn closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: hiddify-next
7 participants