-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hiddify-next: init at 1.1.1 #303085
hiddify-next: init at 1.1.1 #303085
Conversation
b09d97a
to
07f67cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to nixpkgs! Make sure to put new packages in pkgs/by-name
. You can also format your code with nixfmt-rfc-style
When you're done, make sure that you have 2 separate commits in this order:
|
07f67cb
to
7a38808
Compare
All done! thanks for the suggestion and guide. |
7a38808
to
e119d25
Compare
e119d25
to
480d0b6
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3855 |
7e597a8
to
480d0b6
Compare
480d0b6
to
a889c57
Compare
Seems like after 24.05 release,
now the location |
init with appimage version
a889c57
to
32b565f
Compare
Since hidiffy violates the license used by sing-box I thought we shouldn't package it. |
Well, I'm ok with that reason. should we close this PR now or wait for confirmation from others? |
Clost this since #326367 pack it from source. Thanks everyone. |
init with appimage version
fix #285375, related #287770
also add wenjinnn to maintainer-list
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.