Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiddify: init at 1.5.2 #326367

Closed
wants to merge 5 commits into from
Closed

Conversation

BeiyanYunyi
Copy link

@BeiyanYunyi BeiyanYunyi commented Jul 11, 2024

Description of changes

  • Init hiddify at 1.5.2
  • Adds source builder for sqlite3_flutter_libs flutter dependency as needed
  • Add BeiyanYunyi to maintainer-list.nix

Closed #303085 as duplicate (that pr also ships with an older version, and uses AppImage while this compiles from source)

Fix #285375, related to #287770

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 11, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 11, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 11, 2024
@ofborg ofborg bot requested a review from LostAttractor July 11, 2024 19:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 11, 2024
@BeiyanYunyi BeiyanYunyi force-pushed the init/hiddify-next branch 5 times, most recently from 1f4b6af to ccaa6c0 Compare July 12, 2024 07:16
@Cryolitia Cryolitia requested a review from Aleksanaa July 12, 2024 07:28
@BeiyanYunyi BeiyanYunyi marked this pull request as draft July 13, 2024 01:17
BeiyanYunyi and others added 3 commits July 14, 2024 21:28
Co-authored-by: LostAttractor <lostattractor@gmail.com>
Co-authored-by: LostAttractor <lostattractor@gmail.com>
@BeiyanYunyi BeiyanYunyi marked this pull request as ready for review July 14, 2024 14:19
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look fine. Please reword hiddify: init at 1.5.2 to hiddify-next: init at 1.5.2

pkgs/by-name/hi/hiddify-next/package.nix Outdated Show resolved Hide resolved
circle_flags = "sha256-dqORH4yj0jU8r9hP9NTjrlEO0ReHt4wds7BhgRPq57g=";
};

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to avoid with lib

pkgs/by-name/hi/hiddify-next/package.nix Outdated Show resolved Hide resolved
pname = "hiddify-next";
version = "1.5.2";

hiddify = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One may want to make these packages overridable. There are some solutions:

  1. use callPackage to load from another file, as a default argument { ..., hiddify? callPackage ./hiddify.nix {}, ... }: flutter... { ... }, and expose them in passthru of the main package
  2. use callPackages, and write a set of packages, like https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/tools/language-servers/nixd/default.nix
  3. just split them into different by-name directories, and inherit version and src.

BeiyanYunyi and others added 2 commits July 15, 2024 18:43
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@wenjinnn wenjinnn mentioned this pull request Oct 22, 2024
13 tasks
@Tanvir1337x
Copy link
Contributor

Update

Latest Release: v2.0.5
Latest Pre-release: v2.5.7

@BeiyanYunyi
Copy link
Author

Close due to personal conflict with a main contributor of sing-box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: hiddify-next
5 participants