-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hiddify: init at 1.5.2 #326367
hiddify: init at 1.5.2 #326367
Conversation
1f4b6af
to
ccaa6c0
Compare
Co-authored-by: LostAttractor <lostattractor@gmail.com>
Co-authored-by: LostAttractor <lostattractor@gmail.com>
ccaa6c0
to
9b1ad78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others look fine. Please reword hiddify: init at 1.5.2
to hiddify-next: init at 1.5.2
circle_flags = "sha256-dqORH4yj0jU8r9hP9NTjrlEO0ReHt4wds7BhgRPq57g="; | ||
}; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to avoid with lib
pname = "hiddify-next"; | ||
version = "1.5.2"; | ||
|
||
hiddify = fetchFromGitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One may want to make these packages overridable. There are some solutions:
- use
callPackage
to load from another file, as a default argument{ ..., hiddify? callPackage ./hiddify.nix {}, ... }: flutter... { ... }
, and expose them inpassthru
of the main package - use
callPackages
, and write a set of packages, like https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/tools/language-servers/nixd/default.nix - just split them into different by-name directories, and inherit
version
andsrc
.
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
Close due to personal conflict with a main contributor of sing-box. |
Description of changes
sqlite3_flutter_libs
flutter dependency as neededBeiyanYunyi
tomaintainer-list.nix
Closed #303085 as duplicate (that pr also ships with an older version, and uses AppImage while this compiles from source)
Fix #285375, related to #287770
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.