Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: 1.21.10 -> 1.21.11 #304494

Merged
merged 1 commit into from
Apr 17, 2024
Merged

gitea: 1.21.10 -> 1.21.11 #304494

merged 1 commit into from
Apr 17, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 16, 2024

Description of changes

ChangeLog: https://github.com/go-gitea/gitea/releases/tag/v1.21.11

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 16, 2024
@Ma27
Copy link
Member Author

Ma27 commented Apr 16, 2024

Added the security label as a precaution, not sure what to think of go-gitea/gitea#30315 though.
cc @techknowlogick is that worth a backport to 1.20/23.11?

@techknowlogick
Copy link
Member

@Ma27 yes, a backport for this is worth it. lmk if you'd like me to do it. The patch from that linked PR should(tm) apply cleanly to 1.20.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 16, 2024
@SuperSandro2000 SuperSandro2000 merged commit c961077 into NixOS:master Apr 17, 2024
32 checks passed
@Ma27 Ma27 deleted the bump-gitea branch April 17, 2024 12:49
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Apr 17, 2024
@Ma27
Copy link
Member Author

Ma27 commented Apr 17, 2024

@techknowlogick from my understanding the interesting part of the PR linked above was that CSP is now set in any case, correct?
The patch didn't apply cleanly, but I patched the relevant portion manually in #304820.
A review would be greatly appreciated.

zeme-wana pushed a commit to input-output-hk/nixpkgs that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants