Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] gitea: backport CSP patch in markdown renderer #304820

Merged
merged 1 commit into from
May 1, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 17, 2024

See #304494 (comment)

Note: please await a review from @techknowlogick

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 17, 2024
@Ma27 Ma27 mentioned this pull request Apr 17, 2024
13 tasks
@risicle
Copy link
Contributor

risicle commented Apr 21, 2024

Looks right to me & passthru.tests pass, nixos x86_64

@Ma27
Copy link
Member Author

Ma27 commented Apr 21, 2024

ping @techknowlogick

@Ma27
Copy link
Member Author

Ma27 commented May 1, 2024

A review from the upstream devs would've been cool, but given that it got double-checked, I'll merge now.

@Ma27 Ma27 merged commit 8e48b76 into NixOS:release-23.11 May 1, 2024
31 checks passed
@Ma27 Ma27 deleted the backport-gitea-renderer-fix branch May 1, 2024 08:15
@techknowlogick
Copy link
Member

@Ma27 ack, apologies for missing the ping. thanks for merging :)

@Ma27 Ma27 mentioned this pull request May 27, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants