Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyrus-imapd: init at 3.8.2 #305538

Merged
merged 3 commits into from
Oct 20, 2024
Merged

cyrus-imapd: init at 3.8.2 #305538

merged 3 commits into from
Oct 20, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented Apr 20, 2024

Description of changes

This PR was modified from #170919. Since there have been no updates to that PR after October 28, 2023, I have fixed the package and resubmitted.

The previously existing perl cyradm dependency issue no longer exists.

Cyrus-imapd is somewhat difficult to package, I drew on the practices of the cyrus imap debian deb package, but there may still be many problems. I think we need more work to make it more reliable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Apr 20, 2024

Result of nixpkgs-review pr 305538 run on x86_64-linux 1

1 package built:
  • cyrus-imapd

@Moraxyc
Copy link
Contributor Author

Moraxyc commented Apr 20, 2024

@pacien @pingiun @teto

@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch 2 times, most recently from b4f359d to d8a3ff2 Compare April 20, 2024 14:10
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 20, 2024
@ofborg ofborg bot requested a review from pingiun April 20, 2024 14:37
@Moraxyc Moraxyc requested review from teto and pacien May 4, 2024 00:11
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch from d8a3ff2 to 8923a79 Compare May 4, 2024 01:53
@pingiun pingiun mentioned this pull request May 6, 2024
13 tasks
@xyzst
Copy link

xyzst commented May 7, 2024

@Moraxyc would this nix package enable the calendaring (caldav) and contacts (cardav) features in cyrus-imap? Docs seem to imply this needs to be enabled in the configuration file.

https://www.cyrusimap.org/imap/installing.html#checking-carddav-and-caldav

I looked at the changes but I wasn't able to determine if this is the case or not.

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 7, 2024

@xyzst yes it is.
If you want to try cyrus-imap, you could use the package and module in my NUR repo.
https://github.com/Moraxyc/nur-packages/blob/main/modules/cyrus-imap.nix

Copy link
Member

@jtbx jtbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, thanks for your work on this!

pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch from 8923a79 to 65bdaee Compare May 10, 2024 01:54
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 10, 2024
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch 2 times, most recently from e5cd892 to 136de41 Compare May 10, 2024 02:48
@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 10, 2024

@ofborg test cyrus-imap

test Outdated Show resolved Hide resolved
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch from 136de41 to fbb8102 Compare May 10, 2024 07:19
@ofborg ofborg bot requested a review from pingiun May 12, 2024 15:38
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch 2 times, most recently from 95aa457 to 445ddcd Compare May 13, 2024 05:31
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jun 1, 2024
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch from 445ddcd to 84c92ea Compare June 5, 2024 02:00
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch 2 times, most recently from edda038 to 8066666 Compare June 22, 2024 01:41
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jun 22, 2024
@Moraxyc Moraxyc requested review from jtbx and pluiedev June 22, 2024 01:43
nixos/modules/services/mail/cyrus-imap.nix Show resolved Hide resolved
nixos/modules/services/mail/cyrus-imap.nix Show resolved Hide resolved
nixos/modules/services/mail/cyrus-imap.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Show resolved Hide resolved
pkgs/by-name/cy/cyrus-imapd/package.nix Outdated Show resolved Hide resolved
@Moraxyc Moraxyc force-pushed the add-cyrus-imapd branch 2 times, most recently from 3feb484 to a563406 Compare August 22, 2024 08:50
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
Co-authored-by: jtbx <jeremy@baxters.nz>
Co-authored-by: drupol <pol.dellaiera@protonmail.com>
Moraxyc and others added 2 commits October 20, 2024 00:13
Co-authored-by: jtbx <jeremy@baxters.nz>
Co-authored-by: pluiedev <hi@pluie.me>
@Moraxyc
Copy link
Contributor Author

Moraxyc commented Oct 19, 2024

@drupol, could you please have a look in your freetime? This package and module has been delayed for too long, maybe we can finish it before 24.11

@Moraxyc Moraxyc removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 19, 2024
@Moraxyc Moraxyc requested a review from pluiedev October 20, 2024 04:34
@drupol drupol merged commit 88d3f02 into NixOS:master Oct 20, 2024
28 of 29 checks passed
@Moraxyc Moraxyc deleted the add-cyrus-imapd branch October 20, 2024 06:01
@jtbx
Copy link
Member

jtbx commented Oct 20, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants