Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyrus-imapd: fix wrong mainProgram; remove unused inputs #354680

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented Nov 9, 2024

  • fix wrong mainProgram
  • remove unused inputs

I'm not sure if it's a good idea to point it to cyradm. Debian added an extra shell script to call the various executable programs in cyrus-imapd/{bin, libexec}, which is what I original thought of in #305538. But someone said that this is a bit strange, so I removed that part but forgot to modify mainProgram :(

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 9, 2024
@Moraxyc Moraxyc force-pushed the cyrus-imapd-mainprogram branch from ca4574c to 30ffe39 Compare November 23, 2024 14:02
@Moraxyc Moraxyc force-pushed the cyrus-imapd-mainprogram branch from 30ffe39 to 5445bd0 Compare November 23, 2024 18:46
@Aleksanaa Aleksanaa merged commit 29b4442 into NixOS:master Nov 24, 2024
16 of 17 checks passed
@Moraxyc Moraxyc deleted the cyrus-imapd-mainprogram branch November 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants