Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch-bin: 2.0.0 -> 2.3.0 #308328

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

npatsakula
Copy link
Contributor

@npatsakula npatsakula commented May 1, 2024

Description of changes

Hello @junjihashimoto! Can I ask you for review?

Release notes:
https://github.com/pytorch/pytorch/releases/tag/v2.3.0

Fixes:
#299311

Duplicate (I used this commit as baseline):
#302427

Blockers

  1. macos-x86_64 hash is not updated because there is no binaries for it on download.pytorch.org (!): I've created a discussion on discussion.pytorch.org but so far no response.
  2. I tried to fix @pbsds comment but so far I'm not sure that fix works.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@junjihashimoto junjihashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npatsakula
Hi, thank you for working on this issue.
libomp.dylib's path should be fixed.
Could you check this PR?
npatsakula#1

@npatsakula
Copy link
Contributor Author

Hello @junjihashimoto! I've got response from @ptrblck, looks like x86_64-darwin deprecated since libtorch 2.3.0, so I removed this target from libtorch-bin.

Copy link
Member

@junjihashimoto junjihashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@wegank wegank merged commit c5d5276 into NixOS:master May 4, 2024
27 of 28 checks passed
@wegank wegank mentioned this pull request May 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants