-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtorch-bin: 2.0.0 -> 2.2.2 #302427
libtorch-bin: 2.0.0 -> 2.2.2 #302427
Conversation
Result of 1 package failed to build:
3 packages built:
|
Hm, not sure wahat to do about the ocaml package. @bcdarwin could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinpox Thank you for updating it.
Could you change cu118 to cu121? Because pytorch's default(pip) is cu121.
05b9a14
to
f8d6485
Compare
done. |
Ocaml-torch hasn't been updated in a year or so, so not surprising it would eventually break. Happy for you to mark broken for now. |
Hello @pinpox! I've tested new version with hash from this PR on Also I need to mention that 2.2.2 has support of @junjihashimoto, it seems that I need to close my PR as a duplicate. |
@npatsakula |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Result of 3 packages built:
|
Please squash the commits, and could you look into the aarch64-darwin issue? |
7905753
to
dd25cfd
Compare
fixed and squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
aarch64-darwin is still failing, did you forget to push the change? |
Hello @pbsds! My bad, looks like I need your help:
|
I'm not familiar with nor have access to darwin, but as I understand the darwin build sandbox is lacking. Perhaps it passes on your machine since the dyld check is able to match with a dylib on your system that the ofborg builders don't have installed? Comparing the fixupPhase output in the full logs: https://logs.ofborg.org/?attempt_id=e65c3bce-5f6e-450f-9be7-f390bfbb6790&key=nixos%2Fnixpkgs.302427 x86_64-darwin:
aarch64-darwin:
Some seem to be missing |
Could you update the code to use |
dd25cfd
to
0b292ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
builder failure... I'd love to verify the darwin fix @ofborg build libtorch-bin |
Probably platforms = with platforms; [
"aarch64-darwin"
"x86_64-darwin" "x86_64-linux"
]; |
Yes, keep in mind |
0b292ca
to
92c5e1d
Compare
It worked before the push, and now it failed again. |
Superseded by #308328. |
Description of changes
Also fixed the prefetch script, the url seems to have slightly changed Fixes #299311
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.