Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch-bin: 2.0.0 -> 2.2.2 #2

Conversation

npatsakula
Copy link

Hello again!

Looks like I fixed libcxx problem.

@npatsakula npatsakula changed the base branch from master to libtorch-bin-update-newq April 23, 2024 10:00
Also fixed the prefetch script, the url seems to have slightly changed
Fixes NixOS#299311
@@ -99,6 +99,9 @@ in stdenv.mkDerivation {
# https://www.intel.com/content/www/us/en/developer/articles/license/onemkl-license-faq.html
license = licenses.bsd3;
maintainers = with maintainers; [ junjihashimoto ];
platforms = platforms.unix;
platforms = with platforms; [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also fixed platforms list to avoid CI errors.

device = if cudaSupport then "cuda" else "cpu";
srcs = import ./binary-hashes.nix version;
unavailable = throw "libtorch is not available for this platform";
libcxx-for-libtorch = if stdenv.hostPlatform.system == "x86_64-darwin" then libcxx else stdenv.cc.cc.lib;
libcxx-for-libtorch = if stdenv.isDarwin then libcxx else stdenv.cc.cc.lib;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@pinpox pinpox force-pushed the libtorch-bin-update-newq branch 2 times, most recently from 0b292ca to 92c5e1d Compare April 26, 2024 23:28
@npatsakula npatsakula closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants