python311Packages.gradio-client: 0.14.0 -> 0.16.1, python311Packages.gradio: 4.27.0 -> 4.29.0 #310295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
changed the title
GaetanLepage
force-pushed
the
gradio-client
branch
from
7739291 to
875a326
Compare
|
@GaetanLepage Is it ready to be merged? I see this is broken on some archs, can we fix this? |
No it's still broken. I have to go through the logs. |
|
OK I'll wait then, I need this in #305586 |
|
Neat! I have nearly the same diff sitting in a local branch which fixes gradio on py311, but py312 is broken due to two issues in diffusers. The following diff fixes the first issue, but diffusers still fail to build due to test failures. Upstream communicates that the tests should be temporarily disabled now, but i've yet to go hunt down the commits to cherrypick. diff --git a/pkgs/development/python-modules/diffusers/default.nix b/pkgs/development/python-modules/diffusers/default.nix
index 39464efe47fd..8b555462c21b 100644
--- a/pkgs/development/python-modules/diffusers/default.nix
+++ b/pkgs/development/python-modules/diffusers/default.nix
@@ -2,6 +2,7 @@
, stdenv
, buildPythonPackage
, fetchFromGitHub
+, fetchpatch
, pythonOlder
, writeText
, setuptools
@@ -51,6 +52,20 @@ buildPythonPackage rec {
hash = "sha256-aRnbU3jN40xaCsoMFyRt1XB+hyIYMJP2b/T1yZho90c=";
};
+ patches = [
+ # fix python3.12 build
+ (fetchpatch { # https://github.com/huggingface/diffusers/pull/7455
+ name = "001-remove-distutils.patch";
+ url = "https://github.com/huggingface/diffusers/compare/363699044e365ef977a7646b500402fa585e1b6b...3c67864c5acb30413911730b1ed4a9ad47c0a15c.patch";
+ hash = "sha256-Qyvyp1GyTVXN+A+lA1r2hf887ubTtaUknbKd4r46NZQ=";
+ })
+ (fetchpatch { # https://github.com/huggingface/diffusers/pull/7461
+ name = "002-fix-removed-distutils.patch";
+ url = "https://github.com/huggingface/diffusers/commit/efbbbc38e436a1abb1df41a6eccfd6f9f0333f97.patch";
+ hash = "sha256-scdtpX1RYFFEDHcaMb+gDZSsPafkvnIO/wQlpzrQhLA=";
+ })
+ ];
+
nativeBuildInputs = [
setuptools
wheel |
GaetanLepage
force-pushed
the
gradio-client
branch
from
875a326 to
69dfdb8
Compare
|
Result of 6 packages failed to build:
6 packages built:
|
|
Result of 12 packages built:
|
|
Result of 12 packages failed to build:
|
GaetanLepage
force-pushed
the
gradio-client
branch
from
69dfdb8 to
3ca4664
Compare
|
Result of 12 packages failed to build:
|
|
the diffusers commit is bogging down ofborg with timeouts. It's not complete anyway, so lets pop it off and merge the bumps |
|
Thanks for your patch @pbsds. |
|
Basically, it boils down to: |
|
They fail in |
GaetanLepage
force-pushed
the
gradio-client
branch
from
3ca4664 to
c207a5e
Compare
I skipped the dymano test on python 3.12. |
|
Result of 16 packages built:
|
|
Result of 10 packages failed to build:
6 packages built:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
gradio-client is currently broken on
master.Note: this patch is not working yet.
fixes #310761
Changelogs:
cc @pbsds @drupol
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.