python312Packages.diffusers: mark as broken on python 3.12 #310570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
pbsds
changed the title
natsukium
reviewed
May 11, 2024
Comment on lines
+156
to
+158
| # No python 3.12 support. This should be fixed in the next release. | ||
| # See https://github.com/huggingface/diffusers/issues/7809 | ||
| broken = pythonAtLeast "3.12"; |
There was a problem hiding this comment.
I'd like to update disabled instead of meta.broken. Thanks.
disabled = pythonOlder "3.8" || pythonAtLeast "3.12";
|
In the end I fixed it in #310295 by disabling failing tests. |
|
Anyway, thank you for the review @natsukium ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The current release of
diffusersdoes not support python 3.12. Let's mark it as broken until this is fixed.This is an effort at de-polluting
nixpkgs-reviewreports.cc @natsukium
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.