adwaita-icon-theme: 46.0 -> 46.2

[jtojnar]

Description of changes

https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/compare/46.0...46.2

This marks the theme hidden and inherits from AdwaitaLegacy.
The AdwaitaLegacy theme contains icons required by icon-naming-spec that were removed from Adwaita icon theme proper few releases back.
Try installing adwaita-icon-theme-legacy in addition to gnome.adwaita-icon-theme if some apps are missing icons.
See https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 for more info.

Closes #315451

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[JohnRTitor]

I would suggest adding both icon themes to the list of default installation of GNOME.

adwaita-icon-theme is enabled by default on GNOME currently and apps that rely on DEs default icon theme like Kate and Dolphin, see poor experience of users. Ideally GNOME should fix it themselves, but that's not gonna be happening as you can see in the upstream thread.

GNOME desktop itself does not make it clear that one needs to install the "legacy" icon theme.

[bobby285271]

Per icon-theme-spec adwaita-icon-theme should probably just propagate adwaita-icon-theme-legacy so the hicolor-icon-theme setup-hook picks it up, though I don't know if GNOME devs reach agreement on it 🤷

[jtojnar]

It is not clear to me what marking the theme as Hidden will actually do in different libraries and apps. According to the spec, it is supposed to hide it from selection but what should a settings app display in the case such theme is selected/enabled by default. Looks like GNOME Tweaks, at least, only checks for presence of index.theme file so Hidden key is ignored.

[JohnRTitor]

It is not clear to me what marking the theme as Hidden will actually do in different libraries and apps.

Even though it is marked as Hidden, GNOME apps continue to use it. Apps like KDE's Kate, which rely on a theme adhering to the theme, have missing icons due to no other icon themes available to fallback to.

According to the spec, it is supposed to hide it from selection but what should a settings app display in the case such theme is selected/enabled by default. Looks like GNOME Tweaks, at least, only checks for presence of index.theme file so Hidden key is ignored.

GNOME ignores the spec, and does not implement it.

This is already an issue in GNOME 46 according to #315451 (comment), so let's not delay it any further and merge this.

I still think on the distro side we should ship adwaita-icon-theme-legacy by default so that issues like these never occur.

[JohnRTitor]

LGTM, let's merge this

[jtojnar]

This is already an issue in GNOME 46 according to #315451 (comment), so let's not delay it any further and merge this.

This has been an issue long before GNOME 46 – in fact, GNOME 46 was actually one of the few releases that did not remove any icons. So I do not think there is much point in rushing it now.

GNOME ignores the spec, and does not implement it.

There are multiple points where spec can be implemented: on “supplier” side (in icon themes) and on consumer side in apps (through GTK or ¿Qt/KDE libs?).

I am mostly interested in how the latter behave in the absence of inherited theme. The spec does not say anything on that topic.

I still think on the distro side we should ship adwaita-icon-theme-legacy by default so that issues like these never occur.

We could do that for gnome.nix but we probably do not want that globally (e.g. in config/xdg/icons.nix).

And there is also the question of adwaita-icon-theme in buildInputs, which I still do not fully understand. We might need the propagation as Bobby suggests.

[Pandapip1]

LGTM, although I think this PR should probably be targeting the staging branch rather than master.

[JohnRTitor]

LGTM, although I think this PR should probably be targeting the staging branch rather than master.

Not that many rebuilds so it could skip staging.

[JohnRTitor]

@jtojnar if this adwaita-icon-theme update is blocked on something, can we split the legacy theme part to a seperate PR and merge that? It would not break anything AFAIK.

[Pandapip1]

Any updates here?

[Pandapip1]

Is there any reason that this PR is still a draft? The changes look pretty trivial to me.

[jtojnar]

See above #316416 (comment)