Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckstation: 0.1-6658 -> 0.1-6759 #322058

Closed
wants to merge 1 commit into from
Closed

Conversation

qubitnano
Copy link
Contributor

Description of changes

Changelog stenzek/duckstation@v0.1-6658...v0.1-6759

Versions after this tag require a newer shaderc, and the updated duckstation-shaderc didn't compile when I tested with 2024.1 locally. So here's the latest that currently builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from AndersonTorres and guibou June 24, 2024 00:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 24, 2024
@AndersonTorres
Copy link
Member

Hello! Triggered by your PR, I refactored and modified the code in order to not require manual updates.

Can you please test it?

#322093

@qubitnano
Copy link
Contributor Author

Superseded by #322093

@qubitnano qubitnano closed this Jun 24, 2024
@qubitnano qubitnano deleted the duck branch June 24, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants