duckstation: 0.1.6658 -> 0.1.6759 #322093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ofborg
bot
added
11.by: package-maintainer
SuperSamus
reviewed
Jun 24, 2024
13 tasks
|
For info, I have tried to build the most recent version, and the truckload of errors is astounding. |
Pandapip1
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
qubitnano
approved these changes
Jul 1, 2024
wegank
added
the
12.approvals: 1
This was referenced Jul 3, 2024
The build scripts used by upstream require Git commands. Because of this, a `deepClone` is required by fetchFromGitHub. However, keeping `.git` directory around is detrimental to determinism. Because of this, we need to run the Git commands "manually", save their outputs and finally remove `.git`. In order to not pollute the `package.nix`, this peculiar source acquisition is detached to its own file and `callPackage`d. Before this Jesuitic hack, the aforementioned data were obtained and filled by human hands...
Since new versions arrived, we should pin that old piece.
thiagokokada
approved these changes
Jul 22, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Triggered by #322058 and #318574
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.