Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daed: init at 0.8.0 #322220

Merged
merged 1 commit into from
Oct 27, 2024
Merged

daed: init at 0.8.0 #322220

merged 1 commit into from
Oct 27, 2024

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Jun 24, 2024

Description of changes

Add https://github.com/daeuniverse/daed
daeuniverse/flake.nix#33

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 24, 2024
@Moraxyc
Copy link
Contributor

Moraxyc commented Oct 11, 2024

@oluceps , Is this PR still active?

@oluceps
Copy link
Member Author

oluceps commented Oct 11, 2024

@oluceps , Is this PR still active?

Yep.

@oluceps oluceps changed the title daed: init at 0.6.0-unstable-2024-06-16 daed: init at 0.7.0 Oct 11, 2024
@Moraxyc
Copy link
Contributor

Moraxyc commented Oct 11, 2024

@oluceps oluceps changed the title daed: init at 0.7.0 daed: init at 0.8.0 Oct 11, 2024
@oluceps
Copy link
Member Author

oluceps commented Oct 11, 2024

Result of nixpkgs-review pr 322220 run on x86_64-linux 1

1 package built:
  • daed

@oluceps
Copy link
Member Author

oluceps commented Oct 13, 2024

@Moraxyc could you test this?

@Moraxyc
Copy link
Contributor

Moraxyc commented Oct 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 322220


x86_64-linux

✅ 1 package built:
  • daed

@Moraxyc
Copy link
Contributor

Moraxyc commented Oct 14, 2024

After using it for a while, I think the package is functional

Copy link
Contributor

@Moraxyc Moraxyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oluceps oluceps added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 14, 2024
@oluceps
Copy link
Member Author

oluceps commented Oct 17, 2024

#287770

@Aleksanaa Aleksanaa merged commit d4f5c73 into NixOS:master Oct 27, 2024
39 checks passed
@oluceps oluceps deleted the daed branch October 27, 2024 04:31
@gepbird gepbird mentioned this pull request Oct 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants