Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daed: fix pnpm.fetchDeps hash #352056

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Oct 29, 2024

We noticed in #351836 (comment) that daed pnpm hash is out of date, because of #349093 (we tried to search for PRs using pnpm.fetchDeps but GitHub search isn't the best). Sorry for the breakage @oluceps regarding to #322220.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird gepbird requested a review from Scrumplex October 29, 2024 08:47
@ofborg ofborg bot requested a review from oluceps October 29, 2024 10:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352056


x86_64-linux

✅ 1 package built:
  • daed

@Scrumplex Scrumplex merged commit ea1bc25 into NixOS:master Oct 29, 2024
34 of 36 checks passed
@Scrumplex Scrumplex mentioned this pull request Oct 29, 2024
13 tasks
@gepbird gepbird deleted the daed-fix-pnmp-hash branch October 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants