Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm_9: 9.12.2 -> 9.12.3 #351836

Merged
merged 1 commit into from
Nov 1, 2024
Merged

pnpm_9: 9.12.2 -> 9.12.3 #351836

merged 1 commit into from
Nov 1, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Oct 28, 2024

Release: https://github.com/pnpm/pnpm/releases/tag/v9.12.3
Closes #351830

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Oct 28, 2024

I'll start nixpkgs-review on this about 5 hours later.
Edit: it takes a long time because nodejs needs to be rebuilt due to an unrelated merge.

pnpm 10 is coming soon, we already have an alpha release: https://github.com/pnpm/pnpm/releases/tag/v10.0.0-alpha.0. It will change pnpm.fetchDeps hashes as the store layout is different.
I think we can wait for a stable release with packaging unless some people want to use it earlier.

Also I'll look into bumping pnpm 8 to 9/10 after the nixpkgs release cycle and dropping 8 if it's not required by any package.

@MisileLab
Copy link
Contributor

MisileLab commented Oct 29, 2024

I'm doing nixpkgs-review and daed-pnpm-deps already failed due to hash mismatch
I did mismention, sorry Mic92
@gepbird
edit: I gave up nixpkgs-review on nixos because of It takes too long.

@dotlambda
Copy link
Member

daed-pnpm-deps already failed due to hash mismatch

That's also the case in master.

@gepbird
Copy link
Contributor Author

gepbird commented Oct 29, 2024

Thanks for also trying nixpkgs-review, I ended up restarting it and waiting it out overnight. No other failures than daed.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351836


x86_64-linux

❌ 1 package failed to build:
  • daed
✅ 49 packages built:
  • astro-language-server
  • authelia
  • autoprefixer
  • cdxgen
  • clash-verge-rev
  • en-croissant
  • equibop
  • equicord
  • follow
  • gitbutler
  • goofcord
  • heroic
  • heroic-unwrapped
  • homebox
  • legcord
  • lemmy-ui
  • metacubexd
  • misskey
  • modrinth-app
  • modrinth-app-unwrapped
  • n8n
  • overlayed
  • pgrok
  • pgrok.server
  • pnpm (pnpm_9)
  • podman-desktop
  • postcss-cli
  • pot
  • renovate
  • rsshub
  • siyuan
  • sketchybar-app-font
  • stylelint-lsp
  • surrealist
  • syncyomi
  • taler-challenger
  • taler-merchant
  • taler-sync
  • taler-wallet-core
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • vencord
  • vencord-web-extension
  • vesktop
  • vikunja
  • webcord-vencord
  • wrangler
  • youtube-music
  • zenn-cli

@gepbird gepbird requested a review from Scrumplex October 29, 2024 06:32
@gepbird gepbird marked this pull request as ready for review October 29, 2024 06:33
@gepbird gepbird mentioned this pull request Oct 29, 2024
13 tasks
@Scrumplex
Copy link
Member

Merged the daed fix from #352056. So this should now build against master

@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351836


x86_64-linux

✅ 50 packages built:
  • astro-language-server
  • authelia
  • autoprefixer
  • cdxgen
  • clash-verge-rev
  • daed
  • en-croissant
  • equibop
  • equicord
  • follow
  • gitbutler
  • goofcord
  • heroic
  • heroic-unwrapped
  • homebox
  • legcord
  • lemmy-ui
  • metacubexd
  • misskey
  • modrinth-app
  • modrinth-app-unwrapped
  • n8n
  • overlayed
  • pgrok
  • pgrok.server
  • pnpm (pnpm_9)
  • podman-desktop
  • postcss-cli
  • pot
  • renovate
  • rsshub
  • siyuan
  • sketchybar-app-font
  • stylelint-lsp
  • surrealist
  • syncyomi
  • taler-challenger
  • taler-merchant
  • taler-sync
  • taler-wallet-core
  • teleport (teleport_16)
  • teleport.client (teleport_16.client)
  • vencord
  • vencord-web-extension
  • vesktop
  • vikunja
  • webcord-vencord
  • wrangler
  • youtube-music
  • zenn-cli

@Mic92 Mic92 merged commit 586436a into NixOS:master Nov 1, 2024
31 of 32 checks passed
@gepbird gepbird deleted the pnpm-9.12.3 branch November 1, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: pnpm 9.12.2 -> 9.12.3
5 participants