Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass: fix build by using libxml2 with http support #331118

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Jul 30, 2024

Description of changes

Fix grass build by using libxml2 with http support.

Without this patch, grass build fails on confusing

configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library. 

error.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

/cc @landam

@landam
Copy link
Contributor

landam commented Jul 30, 2024

@imincik Tested here. With this PR I am able to build GRASS successfully.

@landam landam mentioned this pull request Jul 30, 2024
@ofborg ofborg bot requested review from willcohen, l0b0, nialov, sikmir, nh2 and autra July 30, 2024 19:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jul 30, 2024
@superherointj superherointj merged commit 4883b91 into NixOS:master Jul 31, 2024
37 of 39 checks passed
imincik added a commit to imincik/grass that referenced this pull request Aug 19, 2024
echoix pushed a commit to OSGeo/grass that referenced this pull request Aug 19, 2024
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants