Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix build by using libxml2 with http support #4196

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Aug 19, 2024

  • CI(deps): Lock file maintenance
  • nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

@neteler neteler added the bug Something isn't working label Aug 19, 2024
@neteler neteler added this to the 8.5.0 milestone Aug 19, 2024
@echoix echoix merged commit 769032f into OSGeo:main Aug 19, 2024
28 checks passed
@echoix
Copy link
Member

echoix commented Aug 19, 2024

Would this build error happen eventually on non-nix builds? Would there be an adaptation that we would need to apply to all of our other builds for this?

@imincik
Copy link
Contributor Author

imincik commented Aug 19, 2024

Would this build error happen eventually on non-nix builds? Would there be an adaptation that we would need to apply to all of our other builds for this?

This issue is caused by removal of default support of http in libxml2 . GRASS must be using it somewhere.

@echoix
Copy link
Member

echoix commented Aug 19, 2024

Would this build error happen eventually on non-nix builds? Would there be an adaptation that we would need to apply to all of our other builds for this?

This issue is caused by removal of default support of http in libxml2 . GRASS must be using it somewhere.

@neteler is there something to do about this?

@neteler
Copy link
Member

neteler commented Aug 20, 2024

This issue is caused by removal of default support of http in libxml2 . GRASS must be using it somewhere.

I wonder how to look for it:

ag libxml2 
mswindows/osgeo4w/liblas-config
46:LIBXML2_INCLUDE_DIR=""
47:if test -n "$LIBXML2_INCLUDE_DIR" ; then 
48:    INCLUDES="$INCLUDES -I$LIBXML2_INCLUDE_DIR"
50:LIBXML2_LIBRARIES=""
51:if test -n "$LIBXML2_LIBRARIES" ; then 
52:    LIBS="$LIBS $LIBXML2_LIBRARIES"

mswindows/crosscompile.sh
302:	libxml2-2.dll \

package.nix
23:, libxml2
82:    libxml2

In my view liblas isn't relevant at all any more (since we support PDAL) and could be dropped.

@echoix
Copy link
Member

echoix commented Aug 20, 2024

Is it a transitive dependency then?

@hellik
Copy link
Member

hellik commented Aug 20, 2024

PDAL doesn't work winGRASS so far; IIRC some c++ compiling/linking issues.

@hellik
Copy link
Member

hellik commented Aug 20, 2024

That's may be the reason for liblas.

landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants