Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD dependencies #15

Merged
merged 40 commits into from
Aug 23, 2024
Merged

CI/CD dependencies #15

merged 40 commits into from
Aug 23, 2024

Conversation

a0x8o
Copy link
Owner

@a0x8o a0x8o commented Aug 23, 2024

grass.jupyter: Add documentation of InteractiveMap Features and Paral…

wxGUI/history: Order commands by time and optimize node refresh (OSGeo#3896

style: Fix Pylint bad-chained-comparison / W3601 (https://github.com/OSGeo/grass/pull/4171[)](https://github.com/a0x8o/grass/commit/38eb7ba16d7d28fbf5d158843596286eb55471cb)

CI(deps): Update github/codeql-action action to v3.26.1 (https://github.com/OSGeo/grass/pull/4177[)](https://github.com/a0x8o/grass/commit/e7c0f65fdec0b09aac924e757b197d040bb397b7)

CI(deps): Update super-linter/super-linter action to v6.9.0 (https://github.com/OSGeo/grass/pull/4179[)](https://github.com/a0x8o/grass/commit/90e26858a4bec25bad50d34ff579d9a201999ee9)

pytest(macOS): Run pytest tests on macOS (https://github.com/OSGeo/grass/pull/4163[)](https://github.com/a0x8o/grass/commit/fa6d31d11a50fc47f56b4fb32ef2096d697fb255)

style: use overwrite and not 'o' flag in Python scripts (https://github.com/OSGeo/grass/pull/4176[)](https://github.com/a0x8o/grass/commit/cc0e2ce0747886e276460446b203a695901bd61c)

CI(deps): Update github/codeql-action action to v3.26.2 (https://github.com/OSGeo/grass/pull/4180[)](https://github.com/a0x8o/grass/commit/5182753d14b9ab6415443581ca1f9baf9ae95f1b)

wxGUI: fix mapCreated signal handling (https://github.com/OSGeo/grass/pull/4174[)](https://github.com/a0x8o/grass/commit/5c1992c138136190163a8a83bd6931c0b766dfc2)

CI: also remove /opt/homebrew from macOS runner (https://github.com/OSGeo/grass/pull/4178[)](https://github.com/a0x8o/grass/commit/ba6cb70a519e8ad433c1c755e7d3c558fbaf9c91)

(46903c0e45c802f809645b745c59265ebc619c58)https://github.com/OSGeo/grass/pull/4139[)](https://github.com/a0x8o/grass/commit/46903c0e45c802f809645b745c59265ebc619c58)

CI(deps): Update pre-commit hook pre-commit/mirrors-clang-format to v…

renovate[bot] and echoix committed last week

r.terraflow: Handle memory reallocation errors gracefully (https://github.com/OSGeo/grass/pull/3970[)](https://github.com/a0x8o/grass/commit/5b1a2a5f5ecf29fe0b9ab02314ef3fefc3539a46)

CI(deps): Update super-linter/super-linter action to v7 (https://github.com/OSGeo/grass/pull/4185[)](https://github.com/a0x8o/grass/commit/cde91d34044a8cbb11c3bca70c8fc337dafb03ca)

utils: sync grass_clang_format script to pre-commit config (https://github.com/OSGeo/grass/pull/4186[)](https://github.com/a0x8o/grass/commit/35e2e4320b8e44a071dc4a58ccc96d6f5650cb7f)

CI(deps): Update rui314/setup-mold digest to 0bf4f07 (https://github.com/OSGeo/grass/pull/4188[)](https://github.com/a0x8o/grass/commit/5606b888bc17943c96a27aa7daadf3e43b3d93a2)

CI(deps): Update ruff to v0.6.1 (https://github.com/OSGeo/grass/pull/4184[)](https://github.com/a0x8o/grass/commit/6e97777a1362b51f98ea2e420d699debb9264ccb)

renovate[bot] and echoix committed last week

CI(deps): Update ubuntu:22.04 Docker digest to adbb901 (https://github.com/OSGeo/grass/pull/4192[)](https://github.com/a0x8o/grass/commit/7ee959a8fa5083670ead00aded10709c3378d327)

renovate[bot] committed last week
nix: fix build by using libxml2 with http support (https://github.com/OSGeo/grass/pull/4196[)](https://github.com/a0x8o/grass/commit/769032fa38ecea285f6e538302e7129884bd1fb1)

CI(deps): Lock file maintenance (https://github.com/OSGeo/grass/pull/4198[)](https://github.com/a0x8o/grass/commit/13e9a1b1ce1a03cc72ec262a59d4972edc76c729)

renovate[bot] committed 4 days ago
style: Fix unnecessary-dunder-call (PLC2801) (https://github.com/OSGeo/grass/pull/4170[)](https://github.com/a0x8o/grass/commit/2cf98dac35a6a3d2ab14120a68e345ff7609ba7d)

r.object.geometry: add json support (https://github.com/OSGeo/grass/pull/4105[)](https://github.com/a0x8o/grass/commit/4d17eb509fceac7fdb4fc3943d74ff620dc6f113)

db.describe: add JSON support (https://github.com/OSGeo/grass/pull/4021[)](https://github.com/a0x8o/grass/commit/309b417b1a528aa8ff03ab7ad9a47aa96ec4d66d)

g.download.location: Print target path in error message (https://github.com/OSGeo/grass/pull/4155[)](https://github.com/a0x8o/grass/commit/a4257a13182275acb50609c43207970d48250da6)

gui: replace python imp library with importlib for python 3.12 (OSGeo#4201

CI(deps): Update github/codeql-action action to v3.26.3 (https://github.com/OSGeo/grass/pull/4199[)](https://github.com/a0x8o/grass/commit/296147767f9a9942bba8ab1409c8183432c7b814)

renovate[bot] committed 3 days ago
startup: Change Location to Project in first-time user messages (OSGeo#4193

g.download.project: rename g.download.location (https://github.com/OSGeo/grass/pull/4187[)](https://github.com/a0x8o/grass/commit/037a5ed0fc11bfd1f267cd1c3309ab9c0049fa7e)

g.download.location: Fix typo in g.download.project call (https://github.com/OSGeo/grass/pull/4205[)](https://github.com/a0x8o/grass/commit/17bf103b17be28cad46895f350fc23dde1b1067b)

CI(deps): Update github/codeql-action action to v3.26.4 (https://github.com/OSGeo/grass/pull/4208[)](https://github.com/a0x8o/grass/commit/2171389179c2e8f596acc43638ef81b4234a560b)

renovate[bot] committed 2 days ago
CI(python): Enable printing of all Python warnings with PYTHONWARNINGS (

CI(pytest): Run pytest tests with Python 3.13 (https://github.com/OSGeo/grass/pull/4209[)](https://github.com/a0x8o/grass/commit/42739e4a266d6f346278ab12a8f470eb0f9be609)

configure: update to latest config.guess and config.sub (https://github.com/OSGeo/grass/pull/4161[)](https://github.com/a0x8o/grass/commit/dd5547fd6a189ced99338de7c21f2f34a73d01da)

db.describe: fix illegal memory access report (https://github.com/OSGeo/grass/pull/4202[)](https://github.com/a0x8o/grass/commit/ff98e4212640bac95e206771573506a37c8822b7)

CI(deps): Update ruff to v0.6.2 (https://github.com/OSGeo/grass/pull/4212[)](https://github.com/a0x8o/grass/commit/92cb84ab2484aaf749d281d86ec31f5feb7828e0)

renovate[bot] committed yesterday
Checks: Fix flake8 F841 (local variable assigned to but never used) i…

i.atcorr: fix plot_filter function in create_iwave (https://github.com/OSGeo/grass/pull/3911[)](https://github.com/a0x8o/grass/commit/120513715d6b93c8257216cb83349fc2d3131b06)

r.out.png: fix consecutive fclose calls on same pointer (https://github.com/OSGeo/grass/pull/4214[)](https://github.com/a0x8o/grass/commit/917ba5890cf34cef9dcbf1477339c1b0caaaaf24)

renovate bot and others added 30 commits August 13, 2024 17:28
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lelization in jupyter_tutorial.ipynb (#4164)



Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
New command ordering, node refresh optimization, and refactoring of the history tree.
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
* style: Fix Pylint bad-chained-comparison / W3601

Pylint rule: https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/bad-chained-comparison.html

* Fix copy and paste typo in comment about Time zones are not supported
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* CI(macOS): Add pytest dependencies to macOS workflow

* CI(macOS): Run pytest tests on macOS

* pytest: Use pytest.importorskip for optional imports

* Mark unpickable tests with xfail when using spawn start method

* grass.script: Example test using functools.partial that works with spawn start method

* CI(macOS): Use if: ${{ !cancelled() }} when appropriate

* Update macos_dependencies.txt

* Apply suggestions from code review

Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

* Add ipython and pyyaml to macos_dependencies.txt

---------

Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
(replaces #4175)

Fixes message

```bash
WARNING: Please update the usage of <v.db.connect>: flag <o> has been
         renamed to <--overwrite>
```
Fixes #4166, something must have changed in the pydispatch library, it looks like before it ignored if the handler didn't have all the parameters.

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
* style: Fix import-self (PLW0406)
Ruff rule: https://docs.astral.sh/ruff/rules/import-self/
1 instance solved

* Solve Pylint W0105: pointless-string-statement for python/grass/pygrass/utils.py

* Fix bad name of ruff rule in pyproject.toml

* Fix missing space in pyproject.toml ruff rules ignore list

* style: Fix native-literals (UP018)

* style: Fix unnecessary-dict-index-lookup (PLR1733)

* style: Fix no-classmethod-decorator (PLR0202)
Ruff rule: https://docs.astral.sh/ruff/rules/no-classmethod-decorator/

1 instance fixed.

* style: Ignore remaining comparison-with-itself (PLR0124) in test_eq

Ruff rule: https://docs.astral.sh/ruff/rules/comparison-with-itself/

1 instance solved

* style: Fix ambiguous-unicode-character-docstring (RUF002)

Ruff rule: https://docs.astral.sh/ruff/rules/ambiguous-unicode-character-docstring/

2 instances solved

* style: Fix unnecessary-generator-list (C400)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-generator-list/

1 instance solved

* style: Fix unnecessary-generator-set (C401)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-generator-set/

2 instances solved

* style: Fix unnecessary-list-comprehension-set (C403)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-list-comprehension-set/

3 instances solved

* style: Ignore 1 instance of sys-version-info-minor-cmp-int (YTT204)

Ruff rule:
https://docs.astral.sh/ruff/rules/sys-version-info-minor-cmp-int/

Correctly checks for only Python 3. Using a tuple would not be less messy, as a second comparison for >= Python 3.0 would be needed.

* style: Fix unnecessary-literal-set (C405)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-literal-set/

2 instances fixed

* Fix copy paste typo in ruff rule comment

* style: Fix implicit-optional (RUF013)

Ruff rule: https://docs.astral.sh/ruff/rules/implicit-optional/

2 instances fixed

* Update scripts/g.extension/g.extension.py

---------

Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
…18 (#4183)

* CI(deps): Update pre-commit hook pre-commit/mirrors-clang-format to v18

* Update clang-format-check.yml to use version 18.1.8

* Format files with clang-format 18.1.8

* Fix missing whitespace around operator (flake8)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
* CI(deps): Update ruff to v0.6.1

* style: Use convention `import xml.etree.ElementTree as ET` for unconventional-import-alias (ICN001)

* checks: Ruff now includes checking of Jupyter notebooks by default

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
* CI(deps): Lock file maintenance

* nix: fix build by using libxml2 with http support

Related nixpkgs PR:
NixOS/nixpkgs#331118

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* style: Fix unnecessary-dunder-call (PLC2801)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-dunder-call/

12 instances fixed. Solves some reported issues by Pylint 3.2.6 through unnecessary-dunder-call / C2801

* style: Fix unnecessary-dunder-call (PLC2801) for __init__
4 instances fixed

* style: Fix unnecessary-dunder-call (PLC2801) using getattr
6 instances fixed

* Ignore PLC2801 in test suite file for preserving meaning of test during the change

* style: Fix unnecessary-dunder-call (PLC2801) for get and set item
3 instances fixed

* style: Fix unnecessary-dunder-call (PLC2801) for repr
1 instance fixed

* Ignore PLC2801 for __del__, as there seems to be some differences between both

* Update pyproject.toml to remove PLC2801 exclusion

* gui.wxpython.mapdisp.main: Remove next(self) from LayerList

* grass.pygrass.vector: Remove next(self) from vector class (old Python 2 iterator)

* Revert "grass.pygrass.vector: Remove next(self) from vector class (old Python 2 iterator)"

This reverts commit f79172c.

* Revert "gui.wxpython.mapdisp.main: Remove next(self) from LayerList"

This reverts commit 9963dd1.
* r.object.geometry: add json support

* debug test failure in ci

* fix tests
* db.describe: add json support

* initialize method args to NULL

* Apply suggestions from code review

Co-authored-by: Corey White <smortopahri@gmail.com>

* update documentation

---------

Co-authored-by: Corey White <smortopahri@gmail.com>
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
* g.download.location: print target path in error message

To be less obscure in case the target location directory already exists:

```
ERROR: Location named <nc_spm_full_v2alpha2> already exists, download
       canceled
```

this PR improves the error message to include the path:

```
g.download.location url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
ERROR: Location named <nc_spm_full_v2alpha2> already exists in
       </home/mneteler/nc_spm_full_v2alpha2>, download canceled
```

This is esp. relevant for scripted usage when the command isn't invoked directly by the user.

In addition, section  of **EXAMPLES** added.

* fix message format

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>

* database -> project

Co-authored-by: Veronica Andreo <veroandreo@gmail.com>

---------

Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
* Update infomanager.py: Change Location for Project in messages

The startup message for first-time users refers to the old Locations. This should be changed to Projects to match the new terminology used in 8.4.

* Update infomanager.py

From Mapset to mapset (all lowercase)

* Apply suggestions from code review

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
echoix and others added 8 commits August 21, 2024 22:30
#4210)

Enables to print all occurrences of warnings, and shows all warnings.
Also replace Python 3.8 by Python 3.9 to keep a total of 3 versions tested
* missing import of pyplot
* fix figures not shown correctly
* fix wrong axes
This patch fixes two issues:

1. In one of the code paths, we are calling fclose on a
   file pointer which could potentially be NULL. Doing that
   would lead to undefined behavior. Check if a file pointer
   is NULL before closing it.

2. If we call fclose on same file pointer twice, in the
   second instance we could be closing file descriptor allocated
   to some other file, which typically happens to a freed
   descriptor.

This issue was found by using cppcheck tool.

Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com>
* r.report: add missing prototype

* lib/db: add missing prototype

* CI: fail macOS runner on -Wstrict-prototypes

* lib/gmath: suppress -Wstrict-prototypes for BLAS/LAPACK wrapper header
@a0x8o a0x8o merged commit b794d95 into a0x8o:main Aug 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.