Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: fix mapCreated signal handling #4174

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

petrasovaa
Copy link
Contributor

Fixes #4166, something must have changed in the pydispatch library, it looks like before it ignored if the handler didn't have all the parameters.

@petrasovaa petrasovaa added bug Something isn't working GUI wxGUI related labels Aug 13, 2024
@petrasovaa petrasovaa added this to the 8.5.0 milestone Aug 13, 2024
@petrasovaa petrasovaa self-assigned this Aug 13, 2024
@github-actions github-actions bot added the Python Related code is in Python label Aug 13, 2024
gui/wxpython/gui_core/forms.py Outdated Show resolved Hide resolved
gui/wxpython/rdigit/g.gui.rdigit.py Outdated Show resolved Hide resolved
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
echoix
echoix previously approved these changes Aug 14, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@petrasovaa petrasovaa merged commit 5c1992c into OSGeo:main Aug 14, 2024
26 checks passed
@petrasovaa petrasovaa deleted the fix-mapCreated-signal branch August 14, 2024 18:49
landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
Fixes OSGeo#4166, something must have changed in the pydispatch library, it looks like before it ignored if the handler didn't have all the parameters.

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Fixes OSGeo#4166, something must have changed in the pydispatch library, it looks like before it ignored if the handler didn't have all the parameters.

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Map is not added to the map window after running analysis
2 participants