-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db.describe: add JSON support #4021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
Related code is in Python
C
Related code is in C
HTML
Related code is in HTML
database
Related to database management
module
docs
tests
Related to Test Suite
labels
Jul 10, 2024
cwhite911
suggested changes
Aug 4, 2024
Co-authored-by: Corey White <smortopahri@gmail.com>
@cwhite911 the pr is ready for review. |
46 tasks
cwhite911
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@echoix can you please merge this PR? |
echoix
approved these changes
Aug 19, 2024
Looks like it triggered this:
|
kritibirda26
added a commit
to kritibirda26/grass
that referenced
this pull request
Aug 20, 2024
Fix issue reported in OSGeo#4021 (comment).
echoix
pushed a commit
that referenced
this pull request
Aug 22, 2024
Fix issue reported in #4021 (comment).
landam
pushed a commit
to landam/grass
that referenced
this pull request
Aug 22, 2024
* db.describe: add json support * initialize method args to NULL * Apply suggestions from code review Co-authored-by: Corey White <smortopahri@gmail.com> * update documentation --------- Co-authored-by: Corey White <smortopahri@gmail.com> Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
landam
pushed a commit
to landam/grass
that referenced
this pull request
Aug 22, 2024
Fix issue reported in OSGeo#4021 (comment).
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
* db.describe: add json support * initialize method args to NULL * Apply suggestions from code review Co-authored-by: Corey White <smortopahri@gmail.com> * update documentation --------- Co-authored-by: Corey White <smortopahri@gmail.com> Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Fix issue reported in OSGeo#4021 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JSON support to db.describe module. The JSON output looks like:
Where
???
was used as special string for unknown in plain format, I have changed it to null. For instance, select, update, delete and insert privilege information field.