Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: Change Location to Project in first-time user messages #4193

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

ecodiv
Copy link
Contributor

@ecodiv ecodiv commented Aug 17, 2024

The startup message for first-time users refers to the old Locations. This should be changed to Projects to match the new naming used in 8.4+.

The startup message for first-time users refers to the old Locations. This should be changed to Projects to match the new terminology used in 8.4.
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Aug 17, 2024
@ecodiv ecodiv changed the title Update infomanager.py: Change Location for Project in messages Update infomanager.py: Change Location to Project in messages Aug 17, 2024
@ecodiv ecodiv requested review from petrasovaa and echoix August 17, 2024 10:56
@echoix
Copy link
Member

echoix commented Aug 17, 2024

@petrasovaa Did we settle on lowercase or uppercase project finally?

@ecodiv
Copy link
Contributor Author

ecodiv commented Aug 17, 2024

@petrasovaa Did we settle on lowercase or uppercase project finally?

That was actually something I was going to ask. In tutorials, starting with a capital allows easier separation from projects, other than GRASS GIS projects. But of course, one can always use e.g., italic or other ways to make that distinction.

@echoix
Copy link
Member

echoix commented Aug 17, 2024

There already has been a long discuss on this, we don't need to open it back. I just don't remember the conclusion

@veroandreo
Copy link
Contributor

@petrasovaa Did we settle on lowercase or uppercase project finally?

Thanks Paulo @ecodiv ! We missed that one

We are using lowercase for "project" unless the word is the start of a sentence of course. And since you are at it please also use lowercase for mapset. Thanks! 🙌

@ecodiv
Copy link
Contributor Author

ecodiv commented Aug 17, 2024

There already has been a long discuss on this, we don't need to open it back. I just don't remember the conclusion

OK, good to know for how to use it in tutorials.

From Mapset to mapset (all lowercase)
@ecodiv ecodiv changed the title Update infomanager.py: Change Location to Project in messages startup: Change Location to Project in first-time user messages Aug 17, 2024
@ecodiv
Copy link
Contributor Author

ecodiv commented Aug 17, 2024

And since you are at it please also use lowercase for mapset. Thanks! 🙌

Done

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want lowercased project, the following would need to be adjusted

gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
gui/wxpython/datacatalog/infomanager.py Outdated Show resolved Hide resolved
ecodiv and others added 2 commits August 18, 2024 07:58
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
@ecodiv
Copy link
Contributor Author

ecodiv commented Aug 18, 2024

If we want lowercased project, the following would need to be adjusted

Committed the suggested changes

@echoix echoix merged commit e1b289f into OSGeo:main Aug 20, 2024
26 checks passed
@neteler neteler added this to the 8.5.0 milestone Aug 21, 2024
landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
…o#4193)

* Update infomanager.py: Change Location for Project in messages

The startup message for first-time users refers to the old Locations. This should be changed to Projects to match the new terminology used in 8.4.

* Update infomanager.py

From Mapset to mapset (all lowercase)

* Apply suggestions from code review

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
…o#4193)

* Update infomanager.py: Change Location for Project in messages

The startup message for first-time users refers to the old Locations. This should be changed to Projects to match the new terminology used in 8.4.

* Update infomanager.py

From Mapset to mapset (all lowercase)

* Apply suggestions from code review

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>

---------

Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants