Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: replace python imp library with importlib for python 3.12 #4201

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

petrasovaa
Copy link
Contributor

imp library was dropped in Python 3.12, it's only used in one place in gui and I fixed it based on Python documentation. I tested it.

@petrasovaa petrasovaa added the GUI wxGUI related label Aug 20, 2024
@petrasovaa petrasovaa added this to the 8.5.0 milestone Aug 20, 2024
@petrasovaa petrasovaa self-assigned this Aug 20, 2024
@github-actions github-actions bot added the Python Related code is in Python label Aug 20, 2024
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems justified and you mention it is tested to still work. It's fine with me

@petrasovaa petrasovaa merged commit fdfec39 into OSGeo:main Aug 20, 2024
27 checks passed
@petrasovaa petrasovaa deleted the replace-imp branch August 20, 2024 17:10
landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants