Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(pytest): Run pytest tests with Python 3.13 #4209

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

echoix
Copy link
Member

@echoix echoix commented Aug 22, 2024

Also replace Python 3.8 by Python 3.9 to keep 3 versions tested.

Closes #4203

Also replace Python 3.8 by Python 3.9 to keep 3 versions tested
@github-actions github-actions bot added the CI Continuous integration label Aug 22, 2024
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we should test the whole range (so also the oldest one we support which is 3.9).

@echoix
Copy link
Member Author

echoix commented Aug 22, 2024

Would we want to install a specific Python version in the Ubuntu gunittest (the full one), and keep the one from Ubuntu in the minimal tests?

@wenzeslaus
Copy link
Member

Would we want to install a specific Python version in the Ubuntu gunittest (the full one), and keep the one from Ubuntu in the minimal tests?

So far the logic was default Ubuntu config PLUS (full OR minimal) configuration of GRASS GIS. If one would have a version specified, then maybe the full one should have latest Python release and the minimal one should have the oldest supported release.

@echoix
Copy link
Member Author

echoix commented Aug 22, 2024

Would we want to install a specific Python version in the Ubuntu gunittest (the full one), and keep the one from Ubuntu in the minimal tests?

So far the logic was default Ubuntu config PLUS (full OR minimal) configuration of GRASS GIS. If one would have a version specified, then maybe the full one should have latest Python release and the minimal one should have the oldest supported release.

That's what I've been imagining for a long time. I feel that currently, there isn't much difference between the two configs. The full isn't really full config (not all optional configuration options and libraries are there), and I think the min isn't the most trimmed down (there's still some --with- in the configure call).

@echoix echoix merged commit 42739e4 into OSGeo:main Aug 22, 2024
27 checks passed
landam pushed a commit to landam/grass that referenced this pull request Aug 22, 2024
Also replace Python 3.8 by Python 3.9 to keep a total of 3 versions tested
@echoix echoix deleted the pytest-3.13 branch August 23, 2024 23:32
@neteler neteler added this to the 8.5.0 milestone Aug 25, 2024
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Also replace Python 3.8 by Python 3.9 to keep a total of 3 versions tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Start checking against Python 3.13
3 participants