Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firedragon: init at 11.15.0-1 #332242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dr460nf1r3
Copy link
Member

@dr460nf1r3 dr460nf1r3 commented Aug 4, 2024

Description of changes

This PR adds firedragon to Nixpkgs. It is a fork of the Floorp browser, with custom branding and opinionated settings.

Source: https://gitlab.com/garuda-linux/firedragon/settings

Todo

  • Get it to build (current error: wasm-ld: error: unknown argument: --undefined-version), full build logs - this error originated in using pkgs/by-name/fi/firedragon-unwrapped as way to build firedragon-unwrapped (CI complained about using callPackage in all-packages.nix, doing it the "traditional" way gets rid of the error. I don't understand this enough to make it work the other way - does anyone else know whats going on here?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dr460nf1r3
Copy link
Member Author

dr460nf1r3 commented Aug 4, 2024

- Attribute `pkgs.firedragon-unwrapped` is a new top-level package using `pkgs.callPackage ./pkgs/applications/networking/browsers/firedragon { /* ... */ }`.
  Please define it in pkgs/by-name/fi/firedragon-unwrapped/package.nix instead.
  See `pkgs/by-name/README.md` for more details.
  Since the second `callPackage` argument is `{ }`, no manual `callPackage` in pkgs/top-level/all-packages.nix is needed anymore.

This PR introduces additional instances of discouraged patterns as listed above. Merging is discouraged but would not break the base branch.
To run locally: ./maintainers/scripts/check-by-name.sh master https://github.com/NixOS/nixpkgs.git

Doing it as outlined makes the entire build fail horribly like that: log.

@PedroHLC PedroHLC removed their request for review August 4, 2024 19:09
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCing @mweinelt, Firefox maintainer, to review this. (I am not sure if we need another firefox fork)

@mweinelt
Copy link
Member

mweinelt commented Aug 5, 2024

I'm not a fan of adding more browser forks. They are not exactly cheap to build and likely don't attract a large enough user base to justify building them every other day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants