rtz: 0.5.3 -> 0.7.0 #337471
rtz: 0.5.3 -> 0.7.0 #337471
Conversation
|
cc @figsoda |
pkgs/tools/misc/rtz/default.nix
Outdated
| @@ -27,6 +27,12 @@ rustPlatform.buildRustPackage rec { | |||
| }; | |||
| }; | |||
|
|
|||
| patches = [ | |||
There was a problem hiding this comment.
Shouldn't this be cargoPatches to correctly work?
There was a problem hiding this comment.
From what I understand, using cargoPatches would be required if the patched Cargo.lock was used as a source for nixpkgs dependency vendoring. Here we have to provide an explicit cargoLock anyway because there is a git dependency that needs to be checked, so the regular patches works fine.
pkgs/tools/misc/rtz/default.nix
Outdated
| patches = [ | ||
| # Use a vendored version of uitoipa-swagger-ui which does not require | ||
| # network access at build time. | ||
| ./vendored-uitoipa-swagger-ui.patch |
There was a problem hiding this comment.
Seems like we could avoid the patch by fetching it ourselves in a FOD and setting SWAGGER_UI_DOWNLOAD_URL to a file: URL.
There was a problem hiding this comment.
Very interesting idea, let me try that.
samueltardieu
force-pushed
the
rtz-0.7.0
branch
from
6586a64 to
dea7b72
Compare
|
@samueltardieu, since no more nightly features are used, |
samueltardieu
force-pushed
the
rtz-0.7.0
branch
from
dea7b72 to
575a9bd
Compare
Good catch, updated. |
samueltardieu
force-pushed
the
rtz-0.7.0
branch
from
575a9bd to
32ad55e
Compare
|
Note: additionally, I've proposed that rtz use the |
|
Anything else to do? (ping @alyssais) |
Sure, I've opened #338589 to try and fix it. |
Description of changes
Changes
Breaking Changes
Major Improvements
Full Changelog: twitchax/rtz@v0.5.3...v0.7.0.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.