Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtz: fix build on darwin #338589

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

samueltardieu
Copy link
Contributor

Description of changes

rtz tests seem to be broken on Darwin after 4478f42.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@samueltardieu samueltardieu mentioned this pull request Aug 31, 2024
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 31, 2024
@ofborg ofborg bot requested a review from figsoda August 31, 2024 10:44
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 31, 2024
@alyssais
Copy link
Member

Mind keeping an eye on it and pinging me once it's built on OfBorg?

@samueltardieu
Copy link
Contributor Author

@alyssais All green on Darwin x86_64 (which was the one failing)

@alyssais alyssais merged commit 7dff189 into NixOS:master Sep 1, 2024
29 of 30 checks passed
@samueltardieu samueltardieu deleted the fix-rtz-on-darwin branch September 11, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants