-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miscellaneous swig3 -> swig4 updates #337609
Conversation
(These results are from before the latest batch of commits.) Result of 14 packages marked as broken and skipped:
11 packages failed to build:
151 packages built:
Result of 19 packages marked as broken and skipped:
86 packages failed to build:
45 packages built:
Linux looks to be in a good state. Darwin is doing badly, but my (naive) regression script points to Can I ask your intentions for this PR – are you going to try and get everything not on |
I was thinking that approach of just bumping the default ( |
I think it would be reasonable just to do the bump, if most of the users of it are expected to take the upgrade as uneventfully as these. We’re going to be doing the same for FFmpeg in the next staging cycle, so pinning stuff that breaks to OTOH, this PR is clearly an improvement so if you wanted to continue with this approach that’s fine with me too. (And of course explicit unnecessary |
Sounds good to me - I'll close this PR and create one PR to lift all possible explicit uses of swig3 and another onto staging to bump the default. |
There’s actually fewer mentions of SWIG in‐tree than I thought, so we can probably just get everything built and fix any regressions before merge, even. Happy to help dig up the regressions if you open a PR to bump the version. |
Description of changes
Unpin a bunch of swig3 dependencies and re-pin them at swig4 (to avoid a treewide
swig = swig4
bump yet, but willing to do that).Everything here should be straightforward - no other non-cosmetic changes required and all packages building fine before and after the bump.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.