-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swig: swig3 -> swig4 #337624
swig: swig3 -> swig4 #337624
Conversation
Thanks for this! Going to figure out a test build to run to make sure this ~basically works before merging. |
I rebased this onto
It’s ~1,000 builds, which is not too bad. Let’s see how it goes overnight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully built the following on aarch64-linux
:
apfel
audit
autodock-vina
babeltrace2
codec2
comedilib
cvc4
dtc
fastnlo-toolkit
freecad
gdal
gdalMinimal
gforth
gnucash
gsm
hamlib_3
highlight
kodi
kodi-gbm
kodi-wayland
libdnf
libftdi
libnl
libnvme
libratbag
libredwg
libsForQt5.libopenshot
libsbml
libselinux
libsemanage
libyafaray
llvmPackages.lldb
mapserver
mlt
mupdf
mysql-workbench
nnpdf
openmm
openturns
partio
pjsip
plfit
proot
python311Packages.pivy
python3Packages.catboost
python3Packages.faiss
python3Packages.fenics
python3Packages.hfst
python3Packages.htseq
python3Packages.ihm
python3Packages.lightgbm
python3Packages.m2crypto
python3Packages.marisa
python3Packages.marisa-trie
python3Packages.mecab-python3
python3Packages.meep
python3Packages.pc-ble-driver-py
python3Packages.py-slvs
python3Packages.pybox2d
python3Packages.pycdio
python3Packages.pygsl
python3Packages.pyscard
python3Packages.pyunbound
python3Packages.sigrok
snagboot
trexio
trilinos
trilinos-mpi
unbound
volume_key
zeek
I didn’t see any obvious regressions from Hydra. python3Packages.pymupdf
fails building a MuPDF with SWIG stuff enabled, but that already happens on master
. I also successfully built gdal
on aarch64-darwin
.
I think this is good to land; thank you! The next cycle will probably be in a couple of weeks. If you want to get involved in pinning anything that happens to break, malob’s status pages can be useful and I’d suggest joining the Staging room on Matrix, but since it looks like this should be an uneventful bump I’m sure we can handle it with our existing resources.
Given the complete lack of regressions here so far, it seems like removing swig3
is in sight, if we can do something about old LLDBs and Gforth. I think dropping support for old versions of LLDB should be okay, as it’s not part of the core LLVM compiler toolchains and it should presumably be reasonably backwards‐compatible. No idea about Gforth, but since it uses a fork anyway, if it becomes the last remaining user we could probably just move the swig3
derivation into its directory…
@bcdarwin The |
Description of changes
Bumps the default version of
swig
.Modest but nonzero breakage expected.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.