Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_19: 19.1.1 -> 19.1.3 #352781

Merged
merged 3 commits into from
Nov 6, 2024
Merged

llvmPackages_19: 19.1.1 -> 19.1.3 #352781

merged 3 commits into from
Nov 6, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Nov 1, 2024 •
edited
Loading

https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.3

bolt is broken on x86_64-darwin on master https://hydra.nixos.org/build/276866191 due to trying to write an archive to the llvm package store. applied upstream change llvm/llvm-project@5909979 to fix.

had to make one tweak to fix the workaround for libclc that our wrappers can't accept -arch. libclc needs a wrapped c++ to get header access but an unwrapped clang.
this fixes https://hydra.nixos.org/build/276170976/nixlog/1/tail

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label Nov 1, 2024
@paparodeo paparodeo force-pushed the llvm-update-19.1.3 branch 5 times, most recently from 0fa0e66 to 089da7b Compare November 4, 2024 19:47
@paparodeo
Copy link
Contributor Author

@ofborg build llvmPackages_19

@paparodeo paparodeo marked this pull request as ready for review November 4, 2024 19:49
@RossComputerGuy
Copy link
Member

Oh, I was kinda wanting to do this after 24.11 heh. Are the fixes important enough for 24.11?

@paparodeo
Copy link
Contributor Author

Oh, I was kinda wanting to do this after 24.11 heh. Are the fixes important enough for 24.11?

why? there were some erroneous symbols left in libc++ for 19.1.0 that were removed in 19.1.2. the change log lists various other bug fixes. seems perfectly acceptable to go in 24.11.

@RossComputerGuy
Copy link
Member

why?

Because it came out after the breaking changes freeze.

@paparodeo
Copy link
Contributor Author

why?

Because it came out after the breaking changes freeze.

bugfixes and minor version updates aren't breaking changes (as long as they don't have breaking changes)
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases

@RossComputerGuy
Copy link
Member

I forgot that it doesn't have breaking changes lol.

@RossComputerGuy
Copy link
Member

RossComputerGuy commented Nov 5, 2024 •
edited
Loading

Result of nixpkgs-review pr 352781 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • magnetophonDSP.ConstantDetuneChorus
  • magnetophonDSP.VoiceOfFaust
9 packages failed to build:
  • emscriptenPackages.json_c
  • emscriptenPackages.json_c.dev
  • emscriptenPackages.libxml2
  • emscriptenPackages.libxml2.bin
  • emscriptenPackages.libxml2.dev
  • emscriptenPackages.libxml2.devdoc
  • emscriptenPackages.xmlmirror
  • emscriptenPackages.xmlmirror.doc
  • emscriptenPackages.zlib
76 packages built:
  • bolt_19 (llvmPackages_19.bolt)
  • bolt_19.dev (llvmPackages_19.bolt.dev)
  • bpf-linker
  • clang_19 (llvmPackages_19.clang)
  • emscripten
  • faust
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2firefox
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faust2sc
  • faustPhysicalModeling
  • faustlive
  • guitarix
  • kapitonov-plugins-pack
  • lld_19 (llvmPackages_19.lld)
  • lld_19.dev (llvmPackages_19.lld.dev)
  • lld_19.lib (llvmPackages_19.lld.lib)
  • lldb_19 (llvmPackages_19.lldb)
  • lldb_19.dev (llvmPackages_19.lldb.dev)
  • lldb_19.lib (llvmPackages_19.lldb.lib)
  • llvmPackages_19.bintools
  • llvmPackages_19.bintools-unwrapped
  • llvmPackages_19.bintoolsNoLibc
  • llvmPackages_19.clang-manpages
  • llvmPackages_19.clang-tools
  • llvmPackages_19.clang-unwrapped
  • llvmPackages_19.clang-unwrapped.dev
  • llvmPackages_19.clang-unwrapped.lib
  • llvmPackages_19.clang-unwrapped.python
  • llvmPackages_19.clangNoCompilerRt
  • llvmPackages_19.clangNoCompilerRtWithLibc
  • llvmPackages_19.clangNoLibc
  • llvmPackages_19.clangNoLibcxx
  • llvmPackages_19.clangUseLLVM
  • llvmPackages_19.clangWithLibcAndBasicRtAndLibcxx
  • llvmPackages_19.compiler-rt
  • llvmPackages_19.compiler-rt-no-libc
  • llvmPackages_19.compiler-rt-no-libc.dev
  • llvmPackages_19.compiler-rt.dev
  • llvmPackages_19.libclc
  • llvmPackages_19.libclc.dev
  • llvmPackages_19.libcxx
  • llvmPackages_19.libcxx.dev
  • llvmPackages_19.libcxxClang
  • llvmPackages_19.libcxxStdenv
  • llvm_19 (llvmPackages_19.libllvm)
  • llvm_19.dev (llvmPackages_19.libllvm.dev)
  • llvm_19.lib (llvmPackages_19.libllvm.lib)
  • llvm_19.python (llvmPackages_19.libllvm.python)
  • llvmPackages_19.libunwind
  • llvmPackages_19.libunwind.dev
  • llvmPackages_19.lldb-manpages
  • llvmPackages_19.lldbPlugins.llef
  • llvmPackages_19.llvm-manpages
  • llvmPackages_19.mlir
  • llvmPackages_19.mlir.dev
  • llvmPackages_19.openmp
  • llvmPackages_19.openmp.dev
  • llvmPackages_19.stdenv
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • open-music-kontrollers.mephisto
  • tambura

@paparodeo
Copy link
Contributor Author

the emscriptenPackages are broken on master

@paparodeo
Copy link
Contributor Author

paparodeo commented Nov 6, 2024 •
edited
Loading

added patch from llvm/llvm-project@5909979 which fixes the bolt darwin build (currently broken on master)
https://hydra.nixos.org/job/nixpkgs/trunk/llvmPackages_19.bolt.x86_64-darwin

paparodeo and others added 3 commits November 6, 2024 15:49
@paparodeo
llvmPackages_19.libclc: use unwrapped clang only
7eb7798 
The build requires an unwrapped clang due to passing in --arch flags.
However, for c++ it doesn't pass in --arch and requires standard headers
so which requires the wrapped compiler.
@paparodeo
llvmPackages_19.bolt: upstream patch to fix darwin build
1ab5205 
llvm/llvm-project@5909979
@paparodeo
llvmPackages_19: 19.1.1 -> 19.1.3
3cd45d0 
https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.3
@paparodeo paparodeo changed the base branch from master to staging November 6, 2024 23:50
@paparodeo
Copy link
Contributor Author

changed to runCommand rather than runCommandLocal and added a comment. moved to staging for reasons.

@emilazy emilazy merged commit a886e49 into NixOS:staging Nov 6, 2024
15 of 16 checks passed
@paparodeo paparodeo deleted the llvm-update-19.1.3 branch November 6, 2024 23:54
@paparodeo
Copy link
Contributor Author

could this get the back port 24.11 label?

@emilazy
Copy link
Member

emilazy commented Nov 18, 2024

No need:

yuyuko:~/Developer/nixpkgs  (empty) (no description set)
❭ nix eval nixpkgs/nixos-24.11#llvmPackages_19.llvm.version
"19.1.3"

It already landed in the previous staging-next cycle, I believe.

@paparodeo paparodeo mentioned this pull request Dec 4, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovek323 lovek323 Awaiting requested review from lovek323

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@rrbutani rrbutani Awaiting requested review from rrbutani

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paparodeo @RossComputerGuy @emilazy