Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_19: 19.1.4 -> 19.1.5 #361678

Merged
merged 1 commit into from
Dec 6, 2024
Merged

llvmPackages_19: 19.1.4 -> 19.1.5 #361678

merged 1 commit into from
Dec 6, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 4, 2024 •
edited
Loading

https://github.com/llvm/llvm-project/releases/tag/llvmorg-19.1.5

https://discourse.llvm.org/t/llvm-19-1-5-released/83455

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Dec 4, 2024
@paparodeo
Copy link
Contributor Author

paparodeo commented Dec 4, 2024 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361678

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • magnetophonDSP.ConstantDetuneChorus
❌ 6 packages failed to build:
  • emscriptenPackages.libxml2
  • emscriptenPackages.libxml2.bin
  • emscriptenPackages.libxml2.dev
  • emscriptenPackages.libxml2.devdoc
  • emscriptenPackages.xmlmirror
  • emscriptenPackages.xmlmirror.doc
✅ 81 packages built:
  • bolt_19
  • bolt_19.dev
  • bpf-linker
  • cargo-llvm-cov
  • clang_19
  • emscripten
  • emscriptenPackages.json_c
  • emscriptenPackages.json_c.dev
  • emscriptenPackages.zlib
  • faust
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2firefox
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faust2sc
  • faustPhysicalModeling
  • faustlive
  • guitarix
  • kapitonov-plugins-pack
  • lld_19
  • lld_19.dev
  • lld_19.lib
  • lldb_19
  • lldb_19.dev
  • lldb_19.lib
  • llvmPackages_19.bintools
  • llvmPackages_19.bintools-unwrapped
  • llvmPackages_19.bintoolsNoLibc
  • llvmPackages_19.clang-manpages
  • llvmPackages_19.clang-tools
  • llvmPackages_19.clang-unwrapped
  • llvmPackages_19.clang-unwrapped.dev
  • llvmPackages_19.clang-unwrapped.lib
  • llvmPackages_19.clang-unwrapped.python
  • llvmPackages_19.clangNoCompilerRt
  • llvmPackages_19.clangNoCompilerRtWithLibc
  • llvmPackages_19.clangNoLibc
  • llvmPackages_19.clangNoLibcxx
  • llvmPackages_19.clangUseLLVM
  • llvmPackages_19.clangWithLibcAndBasicRtAndLibcxx
  • llvmPackages_19.compiler-rt
  • llvmPackages_19.compiler-rt-no-libc
  • llvmPackages_19.compiler-rt-no-libc.dev
  • llvmPackages_19.compiler-rt.dev
  • llvmPackages_19.libclc
  • llvmPackages_19.libclc.dev
  • llvmPackages_19.libcxx
  • llvmPackages_19.libcxx.dev
  • llvmPackages_19.libcxxClang
  • llvmPackages_19.libcxxStdenv
  • llvmPackages_19.libllvm
  • llvmPackages_19.libllvm.dev
  • llvmPackages_19.libllvm.lib
  • llvmPackages_19.libllvm.python
  • llvmPackages_19.libunwind
  • llvmPackages_19.libunwind.dev
  • llvmPackages_19.lldb-manpages
  • llvmPackages_19.lldbPlugins.llef
  • llvmPackages_19.llvm-manpages
  • llvmPackages_19.mlir
  • llvmPackages_19.mlir.dev
  • llvmPackages_19.openmp
  • llvmPackages_19.openmp.dev
  • llvmPackages_19.stdenv
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.VoiceOfFaust
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • open-music-kontrollers.mephisto
  • tambura

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • cargo-llvm-cov
❌ 6 packages failed to build:
  • emscriptenPackages.libxml2
  • emscriptenPackages.libxml2.bin
  • emscriptenPackages.libxml2.dev
  • emscriptenPackages.libxml2.devdoc
  • emscriptenPackages.xmlmirror
  • emscriptenPackages.xmlmirror.doc
✅ 61 packages built:
  • _64gram
  • bolt_19
  • bolt_19.dev
  • bpf-linker
  • clang_19
  • emscripten
  • emscriptenPackages.json_c
  • emscriptenPackages.json_c.dev
  • emscriptenPackages.zlib
  • faust
  • faust2csound
  • faust2firefox
  • faust2jackrust
  • faust2ladspa
  • faust2lv2
  • lld_19
  • lld_19.dev
  • lld_19.lib
  • lldb_19
  • lldb_19.dev
  • llvmPackages_19.bintools
  • llvmPackages_19.bintools-unwrapped
  • llvmPackages_19.bintoolsNoLibc
  • llvmPackages_19.clang-manpages
  • llvmPackages_19.clang-tools
  • llvmPackages_19.clang-unwrapped
  • llvmPackages_19.clang-unwrapped.dev
  • llvmPackages_19.clang-unwrapped.lib
  • llvmPackages_19.clang-unwrapped.python
  • llvmPackages_19.clangNoCompilerRt
  • llvmPackages_19.clangNoCompilerRtWithLibc
  • llvmPackages_19.clangNoLibc
  • llvmPackages_19.clangNoLibcxx
  • llvmPackages_19.clangUseLLVM
  • llvmPackages_19.clangWithLibcAndBasicRtAndLibcxx
  • llvmPackages_19.compiler-rt
  • llvmPackages_19.compiler-rt-no-libc
  • llvmPackages_19.compiler-rt-no-libc.dev
  • llvmPackages_19.compiler-rt.dev
  • llvmPackages_19.libclc
  • llvmPackages_19.libclc.dev
  • llvmPackages_19.libcxx
  • llvmPackages_19.libcxx.dev
  • llvmPackages_19.stdenv (llvmPackages_19.libcxxStdenv)
  • llvmPackages_19.libllvm
  • llvmPackages_19.libllvm.dev
  • llvmPackages_19.libllvm.lib
  • llvmPackages_19.libllvm.python
  • llvmPackages_19.libstdcxxClang
  • llvmPackages_19.libunwind
  • llvmPackages_19.libunwind.dev
  • llvmPackages_19.lldb-manpages
  • llvmPackages_19.lldbPlugins.llef
  • llvmPackages_19.llvm-manpages
  • llvmPackages_19.mlir
  • llvmPackages_19.mlir.dev
  • llvmPackages_19.openmp
  • llvmPackages_19.openmp.dev
  • materialgram
  • mesonlsp
  • telegram-desktop

@paparodeo paparodeo marked this pull request as ready for review December 4, 2024 11:02
@alyssais alyssais added the backport staging-24.11 Backport PR automatically label Dec 4, 2024
alyssais
alyssais approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@alyssais alyssais added backport release-24.11 Backport PR automatically and removed backport staging-24.11 Backport PR automatically labels Dec 4, 2024
@alyssais
Copy link
Member

alyssais commented Dec 4, 2024

If staging-next starts before this is merged, this will cause a staging-next mass rebuild when merged. Might be safer to send it through staging to avoid that.

@alyssais
Copy link
Member

alyssais commented Dec 4, 2024

@qknight @matthewbauer @RaitoBezarius @willcohen looks like Emscripten will need to be updated for this.

@willcohen
Copy link
Contributor

willcohen commented Dec 4, 2024 •
edited
Loading

Hi @alyssais -- you mean because of libxml2 and xmlmirror or something else? Nothing in the changelog is jumping out at me suspiciously. The emscriptenPackages are pretty finicky (at least until something like #217428 reorganizes them, I suppose) and are often broken. emscripten and binaryen both made it to their latest releases a few days ago: #343743

@alyssais
Copy link
Member

alyssais commented Dec 4, 2024

I just saw from @paparodeo's comment that they fail to build here, and I checked that they are currently building on Hydra.

@willcohen
Copy link
Contributor

Gotcha. Okay, I think we're good then -- they were broken on the emscripten bump's nixpkgs-review too (#343743 (comment)), but usually work out okay in hydra afterwards. I haven't dug enough to find out why.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@paparodeo
Copy link
Contributor Author

I just saw from @paparodeo's comment that they fail to build here, and I checked that they are currently building on Hydra.

emscriptenPackages.libxml2 and emscriptenPackages.xmlmirror don't build for me on master and have been broken the past few iterations of updating llvm-19 -- I can't find the hydra attribute

#352781 (comment)
#357453 (comment)

If staging-next starts before this is merged, this will cause a staging-next mass rebuild when merged. Might be safer to send it through staging to avoid that.

was hoping this would be merged before the staging-next cycle but will do

@paparodeo paparodeo changed the base branch from master to staging December 4, 2024 15:38
@alyssais
Copy link
Member

alyssais commented Dec 4, 2024

was hoping this would be merged before the staging-next cycle but will do

It's about to start I think.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@philiptaron philiptaron merged commit eb69690 into NixOS:staging Dec 6, 2024
41 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 6, 2024

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 6, 2024
Merged
1 task
@RossComputerGuy
Copy link
Member

That backport doesn't quite look right, shouldn't that be a staging backport?

@paparodeo
Copy link
Contributor Author

paparodeo commented Dec 6, 2024 •
edited
Loading

That backport doesn't quite look right, shouldn't that be a staging backport?

the backport is fine. on master this is also fine but there are changes in staging-next that makes llvm-19 the default for rustc, linux and darwin which results in a mass rebuild. see: #361678 (comment)

@paparodeo paparodeo deleted the llvm-19-update branch December 6, 2024 05:05
@paparodeo paparodeo mentioned this pull request Dec 19, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron philiptaron approved these changes

@alyssais alyssais alyssais approved these changes

@willcohen willcohen willcohen approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovek323 lovek323 Awaiting requested review from lovek323

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@rrbutani rrbutani Awaiting requested review from rrbutani

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paparodeo @alyssais @willcohen @RossComputerGuy @philiptaron @wegank