Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/labeler.yml: add automatic labeling for more topics #354060

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Nov 6, 2024

We have those labels, no reason not to automatic assign them to prs that touch the specific areas.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2024
@jopejoe1 jopejoe1 merged commit 10ff7c5 into NixOS:master Nov 7, 2024
25 checks passed
@jopejoe1 jopejoe1 deleted the labler branch November 7, 2024 12:29
@zowoq
Copy link
Contributor

zowoq commented Nov 7, 2024

darwin and bsd labels are managed by ofborg. See #348183, #164517

@jopejoe1
Copy link
Member Author

jopejoe1 commented Nov 7, 2024

darwin and bsd labels are managed by ofborg. See #348183, #164517

Will open a pr to fix that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants