Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/labeler.yml: remove darwin and bsd #354229

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Nov 7, 2024

Also added a comment on top of the file as a note for other people wanting to add more topics to the labeler.

Fixes #354060 (comment)_
cc @zowoq

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Nov 7, 2024
@jopejoe1 jopejoe1 requested a review from zowoq November 7, 2024 13:14
@ofborg ofborg bot added 6.topic: bsd Running or building packages on BSD 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 7, 2024
.github/labeler.yml Outdated Show resolved Hide resolved
@jopejoe1 jopejoe1 force-pushed the labler-rm-darwin-bsd branch from 3736464 to e5d280c Compare November 8, 2024 18:49
@github-actions github-actions bot removed 6.topic: darwin Running or building packages on Darwin 6.topic: bsd Running or building packages on BSD labels Nov 8, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@jopejoe1 jopejoe1 merged commit b50cd02 into NixOS:master Nov 8, 2024
11 of 12 checks passed
@jopejoe1 jopejoe1 deleted the labler-rm-darwin-bsd branch November 8, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants