-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpgme: 1.23.2 -> 1.24.0 #354635
gpgme: 1.23.2 -> 1.24.0 #354635
Conversation
meta = { | ||
description = "Python bindings to the GPGME API of the GnuPG cryptography library"; | ||
homepage = "https://dev.gnupg.org/source/gpgme/browse/master/lang/python/"; | ||
inherit (gpgme.meta) changelog license maintainers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge all of meta to not forget anything, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that creates problems with meta.position
but it must be some other problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atemu @eclairevoyant Can you explain why I get
nix-repl> python3.pkgs.gpgme.meta.position
"nixpkgs/pkgs/development/python-modules/gpgme/default.nix:45"
here despite using meta = gpgme.meta // ...
? C.f. #324127 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because, not despite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But removing gpgme.meta //
yields the same meta.position
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think meta.position
is unconditionally overwritten based on pos
(when present), or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some code nitpicks. Thanks for splitting it into a proper python derivation with the import check.
Do I understand the code correctly, that the python derivation depends on the binary library derivation and also executes the configure script in the sources again but does not build the binary library again?
Yes. The configure script at least sets the version, i.e. replaces |
The question is: Is this acceptable for staging-next? Otherwise it won't land in 24.11. |
I'm not sure, lemme ask the staging folks. I would say yes.
Yeah, we should fix this before 24.11's release. |
Well it looks like this won't make it to 24.11, should go back to staging and it can land in there once approved enough. |
I don't understand why
@mweinelt Any idea? |
@dotlambda I think that is the configure script of gpgme which tries to find a suitable python version and they have hardcoded a list :/ Maybe there is an option to tell configure to just use one specific python executable and not search for it, but I did not find that option at first glance. |
@lucc Did you even look at this PR's diff? There's a patch that changes said list. |
Should we merge this anyway and fix Python 3.13 later? |
@ofborg build gpgme.passthru.tests python313.pkgs.gpgme |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-24.11
git worktree add -d .worktree/backport-354635-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-354635-to-staging-24.11
git switch --create backport-354635-to-staging-24.11
git cherry-pick -x b3797b6d48b59ca5d8e1c991278d33ad48bde9bd 29c88a0ce64fed33d93d02605c8420ff42d570ee |
Fix for python313Packages.gpgme: #371188 |
fixes #354166
cc @lucc
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.