Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python313Packages.gpgme: fix build #371188

Merged
merged 1 commit into from
Jan 6, 2025
Merged

python313Packages.gpgme: fix build #371188

merged 1 commit into from
Jan 6, 2025

Conversation

FliegendeWurst
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@FliegendeWurst FliegendeWurst mentioned this pull request Jan 5, 2025
Merged
13 tasks
@nix-owners nix-owners bot requested a review from dotlambda January 5, 2025 17:16
SuperSandro2000
SuperSandro2000 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2025
dotlambda
dotlambda reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch seems no longer necessary.

@FliegendeWurst
Copy link
Member Author

The patch seems no longer necessary.

The Python 3.13 package still requires it, I think? I get the error Please install the python development packages. without it.

@dotlambda dotlambda merged commit e4bf30f into NixOS:master Jan 6, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FliegendeWurst @dotlambda @SuperSandro2000 @wegank