dune_3: 3.16.1 -> 3.17.0

[smorimoto]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[vbgl]

@GrahamcOfBorg build ocamlPackages.hxd ocamlPackages.melange ocamlPackages.ocplib-simplex

[vbgl]

This breaks hxd tests (possible workaround: disable them).

[smorimoto]

For some reason, the dune cache is enabled, and there seems to be an error that cannot create a directory for it. I don't usually use Nix and don't know how to work around this. Can you help me?

[smorimoto]

Related PRs:

• Enable dune cache by default ocaml/dune#10710
• Dune cache: add enabled-except-user-rules setting ocaml/dune#10944

[vbgl]

Here is an other suggestion:

--- a/pkgs/development/ocaml-modules/hxd/default.nix
+++ b/pkgs/development/ocaml-modules/hxd/default.nix
@@ -23,6 +23,10 @@ buildDunePackage rec {
 
   doCheck = true;
 
+  preCheck = ''
+    export DUNE_CACHE=disabled
+  '';
+
   meta = with lib; {
     description = "Hexdump in OCaml";
     homepage = "https://github.com/dinosaure/hxd";

[smorimoto]

@vbgl Isn't this possible for all packages using dune?

[smorimoto]

@GrahamcOfBorg build ocamlPackages.patdiff

[smorimoto]

@GrahamcOfBorg build ocamlPackages.hxd

[smorimoto]

@GrahamcOfBorg build ocamlPackages.hxd

[smorimoto]

@GrahamcOfBorg build ocamlPackages.ligo

[vbgl]

Other newly failing OCaml libraries: ocplib-simplex, melange.

[smorimoto]

@GrahamcOfBorg ocamlPackages.melange

[vbgl]

ocplib-index can be fixed using the following patch:

diff --git a/tests/dune b/tests/dune
index 4fcdd22..b0e0fff 100644
--- a/tests/dune
+++ b/tests/dune
@@ -11,41 +11,3 @@
    standalone_minimal
    standalone_test_strict_bounds)
  (libraries ocplib-simplex zarith))
-
-(rule
- (alias runtest)
- (action
-  (diff solveEmpty.expected solveEmpty.output)
- )
-)
-
-(rule
- (alias runtest)
- (action
-  (diff
-    standalone_minimal_maximization.expected
-    standalone_minimal_maximization.output
-  )
- )
-)
-
-(rule
- (alias runtest)
- (action
-  (diff
-    standalone_minimal.expected
-    standalone_minimal.output
-  )
- )
-)
-
-(rule
- (alias runtest)
- (action
-  (diff
-    standalone_test_strict_bounds.expected
-    standalone_test_strict_bounds.output
-  )
- )
-)
-

[smorimoto]

@vbgl Can you add commits to this PR? I'm completely new to the Nix ecosystem and still don't understand which packages are broken and how.

[vbgl]

I’ve just done it and included in this branch commits from other PRs (#362572 & #363369).

[smorimoto]

Thanks a lot!

[smorimoto]

Thanks a lot!

[nix-backports]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] dune_3: 3.16.1 -> 3.17.0 #365602