Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.melange: disable checks & disable for OCaml 5.0 #363369

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Dec 8, 2024

This fixes current melange packages and makes them compatible with future update of dune.

  • melange-4.0.0-414 does not build with OCaml 5.0.0
  • test suite of melange-4.0.0-414 fails in nixpkgs with OCaml 4.14.2
  • test suite of melange-4.0.0-51 fails in nixpkgs with OCaml 5.1.1
  • test suite of melange-4.0.1-52 would fail in nixpkgs with OCaml 5.2.1 when updating dune to 3.17.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 8, 2024
@vbgl vbgl mentioned this pull request Dec 9, 2024
13 tasks
@smorimoto
Copy link
Contributor

Gentle reminder

@vbgl
Copy link
Contributor Author

vbgl commented Dec 13, 2024

Gentle reminder

To whom?

@vbgl vbgl merged commit 2c8e6ae into NixOS:master Dec 16, 2024
32 checks passed
@vbgl vbgl deleted the ocaml-melange-nocheck branch December 16, 2024 07:31
@vbgl vbgl added the backport release-24.11 Backport PR automatically label Dec 16, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 16, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ocaml 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants