linux_rpi: ignoreConfigErrors #375165
Merged
linux_rpi: ignoreConfigErrors #375165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 37789d9 the ignoreConfigErrors is no longer enabled on aarch64, which fails the rpi kernel build Change-Id: I1f9e21badf53fbfdcd3da561f7c398a353c4e9a9
github-actions
bot
added
6.topic: kernel
nix-owners
bot
requested review from
TredwellGit,
Ma27,
NeQuissimus,
K900 and
thoughtpolice
|
Ack. |
brianmcgillion
added a commit
to brianmcgillion/jetpack-nixos
that referenced
this pull request
Jan 22, 2025
NixOS/nixpkgs#366004 introduced a change that warns and errors out when modules are defined and not acutally set for a particular target. This patch rectifies that by going back the the previous method of ignoring those errors and not breaking the build. Commentary is left inline to explain the situation and possible future solutions. tested against orin agx target for ghaf. there are similar solutions being deployed in nixpkgs to work around this e.g. NixOS/nixpkgs#375165 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
3 tasks
This was referenced Jan 23, 2025
13 tasks
nvmd
added a commit
to nvmd/nixos-raspberrypi
that referenced
this pull request
Jan 24, 2025
… disallowed on aarch64-linux by default since NixOS/nixpkgs@37789d9
Closed
3 tasks
brianmcgillion
added a commit
to brianmcgillion/jetpack-nixos
that referenced
this pull request
Feb 7, 2025
NixOS/nixpkgs#366004 introduced a change that warns and errors out when modules are defined and not acutally set for a particular target. This patch rectifies that by going back the the previous method of ignoring those errors and not breaking the build. Commentary is left inline to explain the situation and possible future solutions. tested against orin agx target for ghaf. there are similar solutions being deployed in nixpkgs to work around this e.g. NixOS/nixpkgs#375165 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
danielfullmer
pushed a commit
to anduril/jetpack-nixos
that referenced
this pull request
Feb 20, 2025
NixOS/nixpkgs#366004 introduced a change that warns and errors out when modules are defined and not acutally set for a particular target. This patch rectifies that by going back the the previous method of ignoring those errors and not breaking the build. Commentary is left inline to explain the situation and possible future solutions. tested against orin agx target for ghaf. there are similar solutions being deployed in nixpkgs to work around this e.g. NixOS/nixpkgs#375165 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 37789d9 the ignoreConfigErrors is no longer enabled on aarch64, which fails the rpi kernel build
Change-Id: I1f9e21badf53fbfdcd3da561f7c398a353c4e9a9
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.