sphinx-jinja: 0.2.1 -> 1.1.0, Python 3 support #45763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Aug 29, 2018
That's described in the Nixpkgs manual. |
GrahamcOfBorg
added
8.has: package (new)
lopsided98
force-pushed
the
sphinx-jinja-update
branch
from
46897ff
to
7a05581
Compare
|
I moved the package to its own file. |
This was referenced Aug 30, 2018
|
@GrahamcOfBorg build sphinx-jinja |
lopsided98
force-pushed
the
sphinx-jinja-update
branch
from
7a05581
to
3e0490f
Compare
lopsided98
force-pushed
the
sphinx-jinja-update
branch
from
3e0490f
to
c48d46a
Compare
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: sphinx-jinja Partial log (click to expand)
|
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: sphinx-jinja Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: sphinx-jinja Partial log (click to expand)
|
9 tasks
|
Superseded by #45890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates sphinx-jinja to the latest version, and enables Python 3 support.
Things done
The main issues with Python 3 support were that the tests were run with pytest when they were designed to be run with nose (pytest tried to inject fixtures into function arguments). Also there is an issue where a UTF-8 file is read in the tests without specifying a codec, which requires the locale to be set to UTF-8.
I also removed the blockdiag dependency, because I could not see how it was required. @nand0p why was blockdiag necessary?
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)