-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.tflearn: 0.2.1 -> 0.3.2 #46102
Conversation
pkgs/top-level/python-packages.nix
Outdated
description = "Deep learning library featuring a higher-level API for TensorFlow"; | ||
homepage = "https://github.com/tflearn/tflearn"; | ||
license = licenses.mit; | ||
src = pkgs.fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are moving Python expressions out of pkgs/top-level/python-packages.nix
into pkgs/development/python-modules/<module>/default.nix
.
Please move the expression there, and call it from pkgs/top-level/python-packages.nix
using callPackage ../development/python-modules/<package> { };
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example refactoring: #45763
@GrahamcOfBorg build pythonPackages.tflearn python3Packages.tflearn |
Failure on aarch64-linux (full log) Attempted: pythonPackages.tflearn, python3Packages.tflearn Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python3Packages.tflearn The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.tflearn Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.tflearn, python3Packages.tflearn Partial log (click to expand)
|
tensorflow itself is broken too on aarch64, but this is out of scope of this pr. |
(cherry picked from commit a9a380b)
[detached HEAD c3796a7] pythonPackages.tflearn: 0.2.1 -> 0.3.2 (#46102) |
Thanks! Backport is above. |
Thanks for the review! |
Motivation for this change
ZHF #45960
first time contributor (not active user of this package either), just wanted to try my hand at this and help out.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)