-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openvswitch: 2.5.4 -> 2.12.0 #53032
openvswitch: 2.5.4 -> 2.12.0 #53032
Conversation
45d4210
to
9700a54
Compare
Bumped version to 2.10.1 and 2.5.6. Rebased on current master |
@GrahamcOfBorg build openvswitch-lts |
9700a54
to
8fd9ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good to me, thanks!
substituteInPlace xenserver/opt_xensource_libexec_interface-reconfigure --replace '/usr/bin/env python' '${python27.interpreter}' | ||
substituteInPlace vtep/ovs-vtep --replace '/usr/bin/env python' '${python27.interpreter}' | ||
substituteInPlace xenserver/opt_xensource_libexec_interface-reconfigure --replace '/usr/bin/env python' '${python.interpreter}' | ||
substituteInPlace vtep/ovs-vtep --replace '/usr/bin/env python' '${python.interpreter}' | ||
''; | ||
|
||
enableParallelBuilding = true; | ||
doCheck = false; # bash-completion test fails with "compgen: command not found" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we disable that test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just replaced python in the previous code. I guess there was work to try make the test run but in was aborted in the end... Should we comment out the tests if someone wants to pickup the work later or delete the whole thing ?
It's on my agenda for tomorrow to check this pull request and preferably merge it 🙂 |
8fd9ebf
to
d58fd74
Compare
Rebased to master and resolved conflicts. I can put myself as a maintainer if this helps! |
Openvswitch was upgraded to the latest stable version (currenty 2.12.0). This remove ovs-monitor-ipsec commands. LTS version is still available using `config.virtualisation.vswitch.package = pkgs.openvswitch-lts` it has been upgraded to 2.5.6. This commit is a split from the original PR NixOS#35127.
d58fd74
to
e8e980e
Compare
Updated to 2.12.0 (support for 4.19 and 4.20 kernels, which are in use in nixos). |
I would really appreciate this being merged! |
- tidy maintainer definition - add kmcopper to maintainers - use https for url fetch - update lts to 2.5.9 - compile with openssl 1.1 - use https for homepage url - use python3 in 2.12
openvswitch improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Feel free to rebase on master as needed. Appreciate the merge and hope to get this accepted. Should we plan to backport this to 19.09 and default to the LTS variant for 19.09 since that is the version there currently?
@offlinehacker we would greatly appreciate a merge here. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks!
Openvswitch was upgraded to the latest
stable version (currenty 2.9.2). This remove ovs-monitor-ipsec
commands.
LTS version is still available using
config.virtualisation.vswitch.package = pkgs.openvswitch-lts
This commit is a split from the original PR #35127.
Motivation for this change
Update openvswitch to a more recent version.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)