Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvswitch improvements #1

Merged
merged 2 commits into from
Nov 14, 2019
Merged

openvswitch improvements #1

merged 2 commits into from
Nov 14, 2019

Conversation

kmcopper
Copy link

@kmcopper kmcopper commented Nov 12, 2019

  • tidy maintainer definition
  • add myself to maintainers
  • use https for url fetch
  • update lts to 2.5.9
  • compile with openssl 1.1 (lts and latest)
  • use https for homepage url
  • use python3 instead of python2 (latest only)
Motivation for this change

Improvements to existing pull request

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @netixx

@netixx
Copy link
Owner

netixx commented Nov 13, 2019

Looks good to me (and works on my setup)!

Did you have anything more you wanted to add or edit ?

@netixx
Copy link
Owner

netixx commented Nov 13, 2019

Also, I don't really know how to proceed with this "nested PR", since I have an outstanding PR in the upstream NixOS#53033.
My plan at the moment is to merge this request in my branch and update the upstream PR (and hope for a merge 👍 ).

@kmcopper
Copy link
Author

kmcopper commented Nov 13, 2019

Wait for a little bit I'm still working on fixing openssl 1.1 support in the LTS branch. I was planning on doing python3 in lts branch but it seems to be a bit more involved than the openssl fixes I almost have completed.

- tidy maintainer definition
- add kmcopper to maintainers
- use https for url fetch
- update lts to 2.5.9
- compile with openssl 1.1
- use https for homepage url
- use python3 in 2.12
@kmcopper
Copy link
Author

Good to go.

@netixx netixx merged commit 0f5366d into netixx:update-openvswitch-2.9.2 Nov 14, 2019
@kmcopper kmcopper deleted the openvswitch-improvements branch November 15, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants