Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-desktop: 1.5.6 -> 1.5.8 #80317

Closed
wants to merge 1 commit into from
Closed

riot-desktop: 1.5.6 -> 1.5.8 #80317

wants to merge 1 commit into from

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Feb 16, 2020

Motivation for this change

Following [cff0aa3] riot-web: 1.5.6 -> 1.5.8

Not tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien
riot-desktop: 1.5.6 -> 1.5.8
b18f129 
Following [cff0aa3] riot-web: 1.5.6 -> 1.5.8
@ofborg ofborg bot requested a review from worldofpeace February 17, 2020 00:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 17, 2020
Ma27
Ma27 reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already 1.5.9: https://github.com/vector-im/riot-web/releases/tag/v1.5.9

@pacien
Copy link
Contributor Author

pacien commented Feb 17, 2020

Superseded by #80357

@pacien pacien closed this Feb 17, 2020
@pacien pacien deleted the riot-v1.5.8 branch February 17, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacien @Ma27