Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.5.8 -> 1.5.9 #80357

Merged
merged 2 commits into from
Feb 18, 2020
Merged

riot-{web,desktop}: 1.5.8 -> 1.5.9 #80357

merged 2 commits into from
Feb 18, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Feb 17, 2020

Motivation for this change

This updates riot web and desktop to the lastest available version.

Not tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien mentioned this pull request Feb 17, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from worldofpeace February 17, 2020 15:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 17, 2020
@worldofpeace
Copy link
Contributor

When I launch it I see this message (this was before this update though)

Seshat isn't installed, event indexing is disabled.

I believe this is element-hq/element-web#11125 and https://github.com/matrix-org/seshat. Being that's not an exception, I expect it to be an experimental feature.

worldofpeace
worldofpeace approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 720fe85 into NixOS:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacien @worldofpeace