haskell: Make haskellPackages.callPackage overridable

[Aver1y]

Motivation for this change

Currently nh2/static-haskell-nix overrides every executable package to add the required options for static compilation. This works, but it would be much nicer to just override callPackage to add these options, so that users can just use callPackage, callCabal2nix and developPackage from the resulting package set and have them work as expected (i.e. generate statically linked executables).

Previously self.callPackage was used in some places and callPackage in others. This patch makes it so that self.callPackage is used consistently, so we can override callPackage and have the overriden version be used everywhere.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[maralorn]

That looks very reasonable to me.

[cdepillabout]

@Aver1y I apologize for basically missing this PR and #88841.

Are you still interested in working on these two PRs?

When reviewing this sort of stuff, it is somewhat hard to know what the exact effect of using things like self, or changing the way extend is handled (#88841). (Well, I guess this PR is significantly easier to eye-ball than #88841.)

Would you also be willing to come up some sort of example that only works when the changes from these two PRs are applied?

[stale]

I marked this as stale due to inactivity. → More info