Override callPackage to statify executables #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the advantage of enabling us to just use survey.haskellPackages.callPackage, callCabal2nix, developPackage directly instead of having to add an override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the advantage of enabling us to just use
survey.haskellPackages.callPackage,callCabal2nixanddevelopPackagedirectly and have them generate static executables.Note that this depends on NixOS/nixpkgs#90271, so you don't want to merge this right now (hence the draft). So before merging we'd want to wait for that to be merged and update the pinned nixpkgs to some rev after that or backport the patch.