-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shaderc: 2019.1 -> 2020.1 #93604
shaderc: 2019.1 -> 2020.1 #93604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
With this bump, building
|
Looks like libplacebo already has a fix for that, but it has not been released yet: https://code.videolan.org/videolan/libplacebo/-/issues/100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
causes a regression in libplacebo
FAILED: src/25a6634@@placebo@sha/glsl_glslang.cc.o
g++ -Isrc/25a6634@@placebo@sha -Isrc -I../src -I../src/include -I../src/include/dummy -I../subprojects/xtalloc/include -I../subprojects/bstr/include -I/nix/store/81iy20n5rhvcm18ha289anygpgq5qyjc-lcms2-2.11-dev/include -I/nix/store/3gmgj9qc3wgbd96b394vamky3d0zzjjd-vulkan-headers-1.2.131.1/include -I/nix/store/psda85jw38cxzqp6fa59vrdipz67h6bk-epoxy-1.5.4-dev/include -I/usr/include/glslang -I/nix/store/crkinam09rw65x4nrjn2wirnfs9l1q51-libplacebo-2.72.0/include/glslang -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=c++11 -Wundef -Wshadow -Wparentheses -Wpointer-arith -fvisibility=hidden -fPIC -pthread -MD -MQ 'src/25a6634@@placebo@sha/glsl_glslang.cc.o' -MF 'src/25a6634@@placebo@sha/glsl_glslang.cc.o.d' -o 'src/25a6634@@placebo@sha/glsl_glslang.cc.o' -c ../src/glsl/glslang.cc
../src/glsl/glslang.cc:226:1: error: cannot convert '<brace-enclosed initializer list>' to 'int' in initialization
226 | };
| ^
I should really read the other comments closely... sorry xD |
This PR got superseded by #94049. |
I should too :/. |
sorry @jansol for not following back up with this |
Motivation for this change
https://github.com/google/shaderc/blob/main/CHANGES
Adds support for more recent features such as the GL_KHR_ray_tracing extension.
Needs
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)