Remove zeroing out logic in modifySoname #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original SONAME is filled with 'X' characters in the modifySoname function. This can cause issues if the .dynstr entry is still referenced in other sections, e.g. some libraries use the SONAME entry as version specifiers.
|
Why has this PR still not been accepted? |
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 17, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 18, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 18, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 18, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 18, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 24, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
lkollar
added a commit
to lkollar/manylinux
that referenced
this pull request
Apr 24, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
This was referenced Apr 24, 2020
mayeut
pushed a commit
to pypa/manylinux
that referenced
this pull request
Apr 25, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
grzanka
pushed a commit
to grzanka/manylinux
that referenced
this pull request
May 20, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
|
@lkollar I think I can help you get this merged if you provide a test case and a bit more explanations why that part of the code is not needed anymore. |
|
Seems like this was added in 764dacc, @darealshinji could you take a look what was the reasoning for zeroing out soname? |
|
Given that this patch is widely used, let's just merge it. |
rdb
pushed a commit
to panda3d/manylinux
that referenced
this pull request
Sep 14, 2020
This patch is a copy of the upstream PR NixOS/patchelf#171. This fixes a bug in patchelf which causes an SONAME entry filled with 'X' values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original SONAME is filled with 'X' characters in the modifySoname
function. This can cause issues if the .dynstr entry is still referenced
in other sections, e.g. some libraries use the SONAME entry as version
specifiers.
Closes: #155