This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Cleanup patch for aarch64 support #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squishykid
requested review from
asuresh4,
jchengsfx,
jrcamp,
keitwb,
molner and
mstumpfx
as code owners
MovieStoreGuy
approved these changes
Aug 27, 2020
|
Ok so basically patchelf 0.11 fixed the corruption issues in the prior version? |
|
Yep, that's it. |
|
I think it might have been fixed in this patch NixOS/patchelf#171 |
|
@keitwb is this okay to merge? I see the old PR as a code smell and this helps address the actual issue rolling forward without some tribal knowledge hack. |
keitwb
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1436 was a bit of a hack- this achieves the same results without ignoring a magic list of shared objects.